Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Address definitions/interfaces from the Payment Request API. #39

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

rayankans
Copy link
Collaborator

The ContactAddress interface used to depends on the PaymentAddress
interface defined in the Payment Request spec. That definition was
recently removed in w3c/payment-request#955.

The ContactAddress interface used to depends on the PaymentAddress
interface defined in the Payment Request spec. That definition was
recently removed in w3c/payment-request#955.
@rayankans rayankans requested a review from beverloo May 11, 2021 15:59
@rayankans
Copy link
Collaborator Author

cc @jcayzac, as per your request in w3c/payment-request#955 (comment)

@beverloo
Copy link
Member

Change SG, but please do add a warning (linking to an open issue on this repo) asking whether this is the right spec for the interface to live, giving it a place for discussion.

@jcayzac
Copy link
Member

jcayzac commented May 12, 2021

cc @jcayzac, as per your request in w3c/payment-request#955 (comment)

Thanks! Also, reiterating the need to review the issues that were closed by w3c/payment-request#955, since they may still be valid in this new context.

Regarding the attributes of ContactAddress (or whetever new name the interface may take if moved in its own document), I think there's an important difference between contact management and payment handling: the former is a simple negotiating between a relying party and the end-user's address book, while the latter had to be very specific on semantics because of the additonal actor in the payment flow (the payment handler). That is why PaymentAddress had global region-independent semantics for its address fields. For an address book entry directly consumed by a relying party I believe the address fields should follow the structure-first region-dependent semantics of the autocomplete atribute instead.

Related

Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy it found a new home 🎉

Also, if I can get Mozilla to support this, it should be (fairly) trivial to refactor the existing PaymentAddress implementation to use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants