Drop PaymentAddress, shipping + billing address support #955

ianbjacobs · 2021-04-21T20:50:21Z

closes #842,
closes #939,

as well as issues raised to add family name, given name, and phonetic name:

closes w3c/contact-picker#69
closes w3c/contact-picker#70

This edit also reduces the number of strings in the specification, which means there are fewer (but still some) strings requiring better lang/dir support.

Also closes the follow address related issues:

closes #902
closes w3c/contact-picker#71
closes #888
closes w3c/contact-picker#72
closes w3c/contact-picker#65
closes #653
closes #615
closes #614
closes #548
closes #537
closes #389

The following tasks have been completed:

Confirmed there are no ReSpec errors/warnings.
Modified Web platform tests
Modified MDN Docs (link)
Has undergone security/privacy review (link)

Implementation commitment:

Safari
Chrome
Firefox
Edge (public signal)

Optional, impact on Payment Handler spec?

If these changes are adopted, then we will also want to make corresponding changes in Payment Handler API to remove API-level data (instead of payment method level data).

Preview | Diff

…tion

ianbjacobs · 2021-04-21T20:51:17Z

This pull request removes a number of features from the specification around addresses and contact information. I have marked it as blocked because it will require some review before we proceed.

marcoscaceres

Gave this a print and run through... changes seem fine.

ianbjacobs · 2021-04-22T02:39:51Z

Thanks @marcoscaceres. I’d like to run this by the group.

marcoscaceres · 2021-04-22T03:13:56Z

Sure, take your time!

danyao

LGTM!

danyao · 2021-04-22T15:04:51Z

index.html

@@ -353,40 +309,12 @@ <h3>
            total: {


Maybe this example can be made more clear by adding a new display item for shipping? e.g.

displayItems: [ { // sub-total }, { // tax }, { label: "Standard shipping", amount: { currency: "GBP", value: "5.00" }, }, ]

… but the label referred to VAT. Fixed the label to refer to shipping

ianbjacobs · 2021-04-29T20:22:16Z

@marcoscaceres,

We discussed this pull request at today's WPWG meeting:
https://www.w3.org/2021/04/29-wpwg-minutes#t01

There were no objections to it.

We have a couple of things to do before a CfC to the WG to proceed (back) to CR
with this edit. But I'll unblock this PR.

Ian

ianbjacobs · 2021-05-04T13:22:08Z

@samuelweiler, can you let us know if removing address features through this pull request would address your concern (raised in #842)? Thank you.

marcoscaceres · 2021-05-05T00:51:58Z

@ianbjacobs, when you merge, please make sure the merge message is clear (e.g., "Remove PaymentAddress, shipping + billing address support" or something similar).

marcoscaceres · 2021-05-05T05:16:44Z

Test removals: web-platform-tests/wpt#28830

2) Removed shipping, contact information to align with PR 955 on PR API w3c/payment-request#955

marcoscaceres · 2021-05-06T04:00:27Z

Filed bugs on Firefox and Safari (links at the top). @rsolomakhin, could you please do the same for Blink?

rsolomakhin · 2021-05-06T12:46:13Z

Filed https://crbug.com/1206261 for Blink.

marcoscaceres · 2021-05-07T05:25:43Z

👋😭 so long PaymentAddress, we hardly knew ye.

w3c/payment-request@486c07a (w3c/payment-request#955) removed the PaymentAddress and PayerErrors objects from the Payment Request specification — as well as removing related members from the PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects. So this change marks PaymentAddress and PayerErrors as deprecated and standard_track:false, as well as all their members, and the related members of the PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects. The change also removes all the spec URLs for the deprecated features (they’re no longer in the spec).

w3c/payment-request@486c07a (w3c/payment-request#955) removed the PaymentAddress and PayerErrors objects from the Payment Request specification — as well as removing related members from the PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects. So this change adds Deprecated and Non-standard banners to the PaymentAddress and PayerErrors articles, as well as to he articles for all their member, and to the articles for the related members of the PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects. The change also removes all the Specifications tables for the deprecated features (they’re no longer in the spec). Related BCD change: mdn/browser-compat-data#10413

w3c/payment-request@486c07a (w3c/payment-request#955) removed the PaymentAddress and PayerErrors objects from the Payment Request specification — as well as removing related members from the PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects. So this change adds Deprecated and Non-standard banners to the PaymentAddress and PayerErrors articles, as well as to the articles for all their member, and to the articles for the related members of the PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects. The change also removes all the Specifications tables for the deprecated features (they’re no longer in the spec). Related BCD change: mdn/browser-compat-data#10413

w3c/payment-request@486c07a (w3c/payment-request#955) removed the PaymentAddress and PayerErrors objects from the Payment Request specification — as well as removing related members from the PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects. So this change marks PaymentAddress and PayerErrors as deprecated and standard_track:false, as well as all their members, and the related members of the PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects. The change also removes all the spec URLs for the deprecated features (they’re no longer in the spec). Related MDN change: mdn/content#4850

sideshowbarker · 2021-05-10T02:36:31Z

FYI, I’ve raised PRs to make corresponding updates to MDN and BCD —

… request 955) (#389) 1) Andre Lyver moved to former editor 2) Removed shipping, contact information to align with PR 955 on PR API w3c/payment-request#955 * minor fix to index.html updated tidyconfig to align with PR API version * remove tidy mark + fixup ws * removed some whitespace Co-authored-by: Marcos Cáceres <marcos@marcosc.com>

marcoscaceres · 2021-05-11T02:27:52Z

@rayankans, wrote:

Is something equivalent to PaymentAddress going to be added to this spec? If not I can just move the definition over to unblock this PR.

Yeah, let's move it over. We can also give it a better name as it's not longer tied to payments.

jcayzac · 2021-05-11T02:52:43Z

@rayankans could you kindly mention me on your issue for moving it? We have some input related to w3c/contact-picker#71 that is not relevant to this repo anymore. Other PaymentAddress-related issues mentioned above may also now apply to ContactAddress.

The ContactAddress interface used to depends on the PaymentAddress interface defined in the Payment Request spec. That definition was recently removed in w3c/payment-request#955.

w3c/payment-request@486c07a (w3c/payment-request#955) removed the PaymentAddress and PayerErrors objects from the Payment Request specification — as well as removing related members from the PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects. So this change adds Deprecated and Non-standard banners to the PaymentAddress and PayerErrors articles, as well as to the articles for all their member, and to the articles for the related members of the PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects. The change also removes all the Specifications tables for the deprecated features (they’re no longer in the spec). Related BCD change: mdn/browser-compat-data#10413

Not implemented by anyone and wasn't in the spec even before w3c/payment-request#955.

This reverts commit 486c07a.

…" (#996) * Revert "Drop PaymentAddress, shipping + billing address support (#955)" This reverts commit 486c07a. * fixup link to create contact address

ianbjacobs added 2 commits April 21, 2021 13:42

remove features and examples related to addresses and contact informa…

045404b

…tion

fix one thing for less data (paymentoptions deleted)

66c5d34

ianbjacobs added the Blocked label Apr 21, 2021

marcoscaceres self-requested a review April 22, 2021 02:09

marcoscaceres approved these changes Apr 22, 2021

View reviewed changes

danyao reviewed Apr 22, 2021

View reviewed changes

ianbjacobs added 2 commits April 22, 2021 10:28

@danyao observed that the comment in the example referred to shipping…

1a1e6a1

… but the label referred to VAT. Fixed the label to refer to shipping

restored tax and now total works. :)

24ec419

ianbjacobs removed the Blocked label Apr 29, 2021

marcoscaceres changed the title ~~Lessdata~~ Drop PaymentAddress, shipping + billing address support May 5, 2021

marcoscaceres added 3 commits May 5, 2021 15:18

Additional test removals

e1d6c56

tidy

17c308d

Fixup more tests

abd9d43

This was referenced May 5, 2021

Add regionCode attribute to PaymentAddress (1.1) #836

Closed

Allow incremental request of billing and shipping address #873

Closed

Add optional description to PaymentShippingOption #910

Closed

ianbjacobs added a commit to w3c/payment-handler that referenced this pull request May 5, 2021

1) Andre Lyver moved to former editor

f756f1a

2) Removed shipping, contact information to align with PR 955 on PR API w3c/payment-request#955

ianbjacobs mentioned this pull request May 5, 2021

Remove support for address, contact info from PR API (align with pull request 955) w3c/payment-handler#389

Merged

8 tasks

marcoscaceres mentioned this pull request May 6, 2021

Remove modifiers #957

Closed

8 tasks

marcoscaceres merged commit 486c07a into gh-pages May 7, 2021

xfq mentioned this pull request May 8, 2021

Add phonetic name as one of PaymentAddress properties w3c/i18n-activity#773

Open

sideshowbarker mentioned this pull request May 10, 2021

Deprecate PaymentAddress, PayerErrors, and related members mdn/browser-compat-data#10413

Merged

sideshowbarker mentioned this pull request May 10, 2021

Deprecate PaymentAddress, PayerErrors, and related members mdn/content#4850

Merged

adrianhopebailie mentioned this pull request May 10, 2021

Should SPC be invokable outside of a PaymentRequest flow? w3c/secure-payment-confirmation#65

Open

rayankans mentioned this pull request May 11, 2021

Move Address definitions/interfaces from the Payment Request API. w3c/contact-picker#39

Merged

tidoust mentioned this pull request May 17, 2021

Drop references to now gone PaymentAddress and AddressErrors interfaces w3c/payment-method-basic-card#89

Closed

This was referenced May 19, 2021

chore(package): update webref saschanaz/types-web#97

Merged

Remove notes about nightly build from PaymentAddress mdn/browser-compat-data#10621

Merged

saschanaz added a commit to saschanaz/browser-compat-data that referenced this pull request May 24, 2021

Remove .regionCode

e747b86

Not implemented by anyone and wasn't in the spec even before w3c/payment-request#955.

dontcallmedom mentioned this pull request Jul 7, 2022

is PaymentRequestUpdateEvent still needed? #991

Closed

Elchi3 mentioned this pull request Aug 31, 2022

Remove pages for AddressErrors mdn/content#20167

Merged

marcoscaceres added a commit that referenced this pull request Sep 20, 2022

Revert "Drop PaymentAddress, shipping + billing address support (#955)"

a614a50

This reverts commit 486c07a.

marcoscaceres added a commit that referenced this pull request Sep 21, 2022

Revert "Drop PaymentAddress, shipping + billing address support (#955)"

4027a43

This reverts commit 486c07a.

marcoscaceres added a commit that referenced this pull request Sep 21, 2022

Revert "Drop PaymentAddress, shipping + billing address support (#955)"

7bdd13c

This reverts commit 486c07a.

wbamberg mentioned this pull request Jan 6, 2024

Fix broken links in Payment API mdn/content#31526

Merged

marcoscaceres added a commit that referenced this pull request Feb 5, 2024

Revert "Drop PaymentAddress, shipping + billing address support (#955)"

ce4a1ab

This reverts commit 486c07a.

marcoscaceres added a commit that referenced this pull request Jul 8, 2024

Revert "Drop PaymentAddress, shipping + billing address support (#955)"

ad07ae5

This reverts commit 486c07a.

marcoscaceres added a commit that referenced this pull request Jul 15, 2024

Revert "Drop PaymentAddress, shipping + billing address support (#955)"

14c0e76

This reverts commit 486c07a.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop PaymentAddress, shipping + billing address support #955

Drop PaymentAddress, shipping + billing address support #955

ianbjacobs commented Apr 21, 2021 •

edited by pr-preview bot

Loading

ianbjacobs commented Apr 21, 2021

marcoscaceres left a comment

ianbjacobs commented Apr 22, 2021

marcoscaceres commented Apr 22, 2021

danyao left a comment

danyao Apr 22, 2021

ianbjacobs commented Apr 29, 2021

ianbjacobs commented May 4, 2021

marcoscaceres commented May 5, 2021

marcoscaceres commented May 5, 2021

marcoscaceres commented May 6, 2021

rsolomakhin commented May 6, 2021

marcoscaceres commented May 7, 2021

sideshowbarker commented May 10, 2021

marcoscaceres commented May 11, 2021

jcayzac commented May 11, 2021 •

edited

Loading

Drop PaymentAddress, shipping + billing address support #955

Drop PaymentAddress, shipping + billing address support #955

Conversation

ianbjacobs commented Apr 21, 2021 • edited by pr-preview bot Loading

ianbjacobs commented Apr 21, 2021

marcoscaceres left a comment

Choose a reason for hiding this comment

ianbjacobs commented Apr 22, 2021

marcoscaceres commented Apr 22, 2021

danyao left a comment

Choose a reason for hiding this comment

danyao Apr 22, 2021

Choose a reason for hiding this comment

ianbjacobs commented Apr 29, 2021

ianbjacobs commented May 4, 2021

marcoscaceres commented May 5, 2021

marcoscaceres commented May 5, 2021

marcoscaceres commented May 6, 2021

rsolomakhin commented May 6, 2021

marcoscaceres commented May 7, 2021

sideshowbarker commented May 10, 2021

marcoscaceres commented May 11, 2021

jcayzac commented May 11, 2021 • edited Loading

ianbjacobs commented Apr 21, 2021 •

edited by pr-preview bot

Loading

jcayzac commented May 11, 2021 •

edited

Loading