Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cssom] Is LegacyNullToEmptyString allowed on CSSOMString? #5010

Closed
andruud opened this issue Apr 27, 2020 · 2 comments
Closed

[cssom] Is LegacyNullToEmptyString allowed on CSSOMString? #5010

andruud opened this issue Apr 27, 2020 · 2 comments
Labels
cssom-1 Current Work

Comments

@andruud
Copy link
Member

andruud commented Apr 27, 2020

WebIDL:

The [LegacyNullToEmptyString] extended attribute must not be associated with a type that is not DOMString. [1]

But cssom uses it in many places, and associates it with CSSOMString. Came up since Blink's IDL compiler won't accept [LegacyNullToEmptyString] on CSSOMString, which (so far) appears to be the right behavior.
@tabatkins
Copy link
Member

I mean, clearly it's not allowed. But perhaps it should be? Or it looks like maybe we can just move it to the DOMString in the typedef?

@fantasai fantasai added the cssom-1 Current Work label Jul 23, 2020
@emilio emilio mentioned this issue Sep 3, 2020
Merged
@emilio
Copy link
Collaborator

emilio commented Sep 3, 2020

I think it should be allowed on USVString at least. I opened whatwg/webidl#915 for that.

Moving to the DOMString in the typedef doesn't quite work as not all CSSOMStrings use it.

domenic pushed a commit to whatwg/webidl that referenced this issue Sep 3, 2020
@emilio
Allow to use LegacyNullToEmptyString on USVString
6bccbca 
This is needed for the CSSOM spec, as that allows to use USVString as
the underlying string type. See
w3c/csswg-drafts#5010.
@emilio emilio closed this as completed Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cssom-1 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andruud @tabatkins @fantasai @emilio