Allow to use LegacyNullToEmptyString on USVString. #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for the CSSOM spec, as that allows to use USVString as the underlying string type. Given the USVString conversion to JS values is already calling into the DOMString conversion, there's no need to modify that section even, which is great.
domenic
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
As sad as I am about the interop issue that is CSSOMString, this does seem like approximately the right fix. (E.g., the idea of only applying it to the DOMString typedef would be weird, as then the behavior would differ in browsers which use DOMString vs. USVString.)
There's a separate issue where it's not clear that extended attributes properly flow across typedefs; see #649. But the intent is clear enough, and that can be fixed orthogonally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the CSSOM spec, as that allows to use USVString as
the underlying string type.
Given the USVString conversion to JS values is already calling into the
DOMString conversion, there's no need to modify that section even, which
is great.
cc w3c/csswg-drafts#5010