-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-align][css-grid][css-flexbox][css-multicol][css-tables] A proposal for a Gap Decorations feature #6748
Comments
After a quick read I'm generally a fan of this, it's a feature I know people really want in grid in particular. As mentioned in my comment on #6746 however, I'd like to see this specced along with block dimension overflow for multicol, which I'd like to do in Level 2 of the spec. I think from an author standpoint, the resulting column rows would be where the row gap would be expected. It's also possible to style spanners already with borders and margins whereas it won't be possible to style the gap between rows of column boxes. |
Thank you again for the detailed proposal for gap decorations, @MatsPalmgren! I really love to see this feature getting traction. I've read through the specification now and I wrote down all the things that came to my mind while reading. Some points are bigger, others smaller. Some are very general, some very specific and some are asking for clarification. I tried to group the points to make it a bit easier to go through them. General
Specifications
Editorial / questions
You see, I tried to provide detailed feedback. That's why the list may seem be a bit overwhelming. Though I hope it still helps the discussion and to push the spec. forward. Sebastian |
…spec. NPOTB DONTBUILD A few changes to address some of the feedback in: w3c/csswg-drafts#6748 (comment) I moved the definition of the lateral/longitudinal axes earlier in the document so that they can be used for the rule-image-* section too. I also tweaked the borders/rule-colors in the last example to make it clearer. Differential Revision: https://phabricator.services.mozilla.com/D132971
…spec. NPOTB DONTBUILD A few changes to address some of the feedback in: w3c/csswg-drafts#6748 (comment) I moved the definition of the lateral/longitudinal axes earlier in the document so that they can be used for the rule-image-* section too. I also tweaked the borders/rule-colors in the last example to make it clearer. Differential Revision: https://phabricator.services.mozilla.com/D132971
@SebastianZ Thanks for your detailed feedback - much appreciated! I'll reply inline below:
I don't have an opinion on that - I'll leave it for the CSSWG to decide.
If you're referring to the
Again, the slicing is always done in the rule's longitudinal axis, so it's neither flow-relative, nor physical. I've changed it to refer to the image size in the longitudinal axis instead.
Thanks for the heads up. We can add that after it's added to the css-backgrounds spec.
I honestly think that the model I propose is simpler than specifying both an alignment and an offset relative to that anchor point. What you suggest is basically just merging the It seems easier to learn a sizing model that we already use in other places in CSS, for example the I also use the same model is used in both axes -- it's completely symmetrical. I also think it's more expressive -- without lateral inset properties you have to resort to I agree the word 'longitudinal' is a rather long though... I discussed this with @dholbert , but we couldn't think of a better replacement for lateral/longitudinal. Again, I think the sizing model I propose is simpler for two reasons:
I think this will make it easier for authors to learn than having a separate model for each axis. I've added more examples to these sections in an attempt to make it a bit more pedagogical... I suspect that any perceived complexity is likely just that the spec doesn't explain it in a pedagogical way, but that's something we can fix hopefully.
If we add
That would be rather confusing since I note that @fantasai /@mirisuzanne used the words I'll stick to
We already have for example
I think it's simpler to have separate properties for separate concerns. I also suspect that combining them would make it less expressive.
That's fair. I don't know what's useful to authors so I basically just added all possibilities :-)
Right, but what we're concerned about are changes to table layout. This feature does not affect layout at all, it's purely an addition to the painting phase, so it isn't a big deal to support tables IMO.
That's intentional,
OK, I added a reference to the section about "resolving a rule’s position and size".
If you have an explicit width/height that is larger than the tracks then you get spacing at the edges.
By "start-most" I meant the first track at the start of the axis. I changed it to use first/last instead - hopefully that's clear enough...
No, it's a blue border that is semi-transparent, but you're right it's a bit hard to see. I've updated the example.
No, that grid has Again, thanks for all the feedback! (I've updated the draft spec.) |
I'm thinking if there shouldn't be some extra, more logical properties, like Have Add to that |
@Wolfeur wrote:
Please let's discuss adding logical properties for them in its own issue! The initial proposal is already huge and I suspect the introduction of logical properties may require some separate discussion.
This was my initial proposal in issue #2748.
I am against adding specific property names as aliases just for one type of layout they're used in, even when "column" and "row" may not make sense in some situations. Note that the properties introduced here are meant to apply to grid, flexbox, multi-column, and table layout. Sebastian |
Hey all! I'm looking for the most up-to-date info on progress here. I see this issue hasn't been updated in about a year - is there a more appropriate place to look? |
This is a concrete proposal for a gap decorations feature that covers the use cases and ideas discussed in the issues #2748 and #5080. (I've made a prototype implementation of this in Gecko to ensure it's feasible to implement.)
I'd appreciate any feedback you might have on this proposal in this issue. Thank you.
The text was updated successfully, but these errors were encountered: