Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scroll-animations-1] Physical axis names mismatch #8666

Closed
fantasai opened this issue Mar 31, 2023 · 6 comments
Closed

[scroll-animations-1] Physical axis names mismatch #8666

fantasai opened this issue Mar 31, 2023 · 6 comments
Labels
Closed Accepted by CSSWG Resolution scroll-animations-1 Current Work

Comments

@fantasai
Copy link
Collaborator

scroll-snap-type uses x and y, but scroll-timeline-axis uses horizontal and vertical. We should get these aligned. :)
@fantasai fantasai added scroll-animations-1 Current Work Agenda+ Async Resolution: Proposed Candidate for auto-resolve with stated time limit and removed Agenda+ labels Mar 31, 2023
@fantasai
Copy link
Collaborator Author

fantasai commented Apr 3, 2023

Proposal: rename horizontal and vertical keywords in Scroll Animations to x and y to match Scroll Snap (scroll-snap-type) and Overflow (overflow-x/y).

@astearns
Copy link
Member

astearns commented Apr 4, 2023

@birtles @flackr @graouts any concerns before I send out a proposed resolution to www-style?

@birtles
Copy link
Contributor

birtles commented Apr 10, 2023

Seems reasonable to me.

@flackr
Copy link
Contributor

flackr commented Apr 11, 2023

Sounds good to me.

@astearns
Copy link
Member

Looks like enough consensus to me :)

The CSSWG will automatically accept this resolution one week from now if no objections are raised here. Anyone can add an emoji to this comment to express support. If you do not support this resolution, please add a new comment.

Proposed Resolution: Rename horizontal and vertical keywords in Scroll Animations to x and y to match Scroll Snap (scroll-snap-type) and Overflow (overflow-x/y).

@astearns
Copy link
Member

Resolved: Rename horizontal and vertical keywords in Scroll Animations to x and y to match Scroll Snap (scroll-snap-type) and Overflow (overflow-x/y).

@astearns astearns removed the Async Resolution: Proposed Candidate for auto-resolve with stated time limit label Apr 20, 2023
andruud added a commit to andruud/csswg-drafts that referenced this issue Apr 27, 2023
@andruud
[scroll-animations-1] Rename physical axes to x/y
ce1b138 
w3c#8666
@andruud andruud mentioned this issue Apr 27, 2023
Merged
fantasai pushed a commit that referenced this issue Jun 1, 2023
@andruud @fantasai
[scroll-animations-1] Rename physical axes to x/y
8235c07 
#8666
@fantasai fantasai closed this as completed Jun 1, 2023
@bramus bramus mentioned this issue Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted by CSSWG Resolution scroll-animations-1 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@flackr @fantasai @birtles @astearns