Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scroll-animations-1] Rename physical axes to x/y #8774

Merged
merged 1 commit into from
Jun 1, 2023
Merged

[scroll-animations-1] Rename physical axes to x/y #8774

merged 1 commit into from
Jun 1, 2023

Conversation

andruud
Copy link
Member

@andruud andruud commented Apr 27, 2023

@andruud
Copy link
Member Author

andruud commented Apr 27, 2023

@fantasai Please have a look.

The keyword order most consistent with scroll snap would be x | y | block | inline, but I figured the initial value should come first ...

@andruud andruud requested a review from fantasai April 27, 2023 12:13
@fantasai fantasai merged commit 8235c07 into w3c:main Jun 1, 2023
@andruud andruud deleted the issue_8666 branch June 2, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bramus bramus bramus approved these changes

@fantasai fantasai Awaiting requested review from fantasai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andruud @bramus @fantasai