Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "vbr" & "cbr" to "variable" & "constant" per TAG review. #210

Merged
merged 1 commit into from Dec 16, 2020
Merged

Update "vbr" & "cbr" to "variable" & "constant" per TAG review. #210

merged 1 commit into from Dec 16, 2020

Conversation

sizeak
Copy link
Contributor

@sizeak sizeak commented Dec 16, 2020

A request was raised in the W3C TAG review for #185 to change the BitrateMode enum values to "constant" and "variable".


Preview | Diff

@w3cbot
Copy link

w3cbot commented Dec 16, 2020

dontcallmedom marked as non substantive for IPR from ash-nazg.

@sizeak
Copy link
Contributor Author

sizeak commented Dec 16, 2020

Hi, I don't have write access @dontcallmedom , would you mind merging it please? Thanks.

@dontcallmedom
Copy link
Member

@simoncent can you confirm my impression that no browser has implemented this yet?

(if there were existing implementations shipping, I would want confirmation from implementors before merging)

@sizeak
Copy link
Contributor Author

sizeak commented Dec 16, 2020

I have an open PR for Chrome/Chromium which I will update with this change, but I am unaware of any other implementations.

@dontcallmedom dontcallmedom merged commit 5f712b8 into w3c:master Dec 16, 2020
github-actions bot added a commit that referenced this pull request Dec 16, 2020
…de-enum

Update "vbr" & "cbr" to "variable" & "constant" per TAG review.

SHA: 5f712b8
Reason: push, by @dontcallmedom

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sizeak sizeak deleted the update-bitrate-mode-enum branch December 16, 2020 15:15
@dontcallmedom dontcallmedom linked an issue Jun 4, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use non-abbreviated terms in bitrates
3 participants