Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "vbr" & "cbr" to "variable" & "constant" per TAG review. #210

Merged
merged 1 commit into from Dec 16, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions MediaRecorder.bs
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ interface MediaRecorder : EventTarget {
then initialize |recorder|'s {{MediaRecorder/audioBitrateMode}} attribute to the value of
|options|' {{MediaRecorderOptions/audioBitrateMode}} member,
else initialize |recorder|'s {{MediaRecorder/audioBitrateMode}} attribute to the value
"vbr".</li>
"variable".</li>
<li>Return |recorder|.</li>
</ol></dd>
</dl>
Expand Down Expand Up @@ -530,7 +530,7 @@ dictionary MediaRecorderOptions {
unsigned long audioBitsPerSecond;
unsigned long videoBitsPerSecond;
unsigned long bitsPerSecond;
BitrateMode audioBitrateMode = "vbr";
BitrateMode audioBitrateMode = "variable";
};
</pre>

Expand Down Expand Up @@ -570,18 +570,18 @@ dictionary MediaRecorderOptions {

<pre class="idl">
enum BitrateMode {
"cbr",
"vbr"
"constant",
"variable"
};
</pre>

### Values ### {#bitratemode-values}

<dl class="domintro">
<dt><dfn enum-value for="BitrateMode"><code>cbr</code></dfn></dt>
<dt><dfn enum-value for="BitrateMode"><code>constant</code></dfn></dt>
<dd>Encode at a constant bitrate.</dd>

<dt><dfn enum-value for="BitrateMode"><code>vbr</code></dfn></dt>
<dt><dfn enum-value for="BitrateMode"><code>variable</code></dfn></dt>
<dd>Encode using a variable bitrate, allowing more space to be used for complex signals
and less space for less complex signals.</dd>
</dl>
Expand Down