Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reference to issue #50. #84

Closed
wants to merge 3 commits into from
Closed

Conversation

msporny
Copy link
Member

@msporny msporny commented Mar 16, 2016

Add a reference to issue #50.

might happen via a NOTE or similar mechanism to ensure that people know
it won't be just the OS vendors providing payment apps.
</p>

<p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msporny For consistency, I think the issue markers for issues #50, #39 should follow a similar format as they both relate to payment app interface (one for native apps and the other for web based apps).

I would suggest the following text and would include this at an appropriate point in the section User Agent delegates payment request algorithm and possibly another reference in the complete() section as this refers to messages being passed back to the payment app.

Suggested text:

<p class="issue" data-number="50" title="It is unclear how the user agent will interface with 
a native payment app.">This specification should describe how the user-agent will pass the payment request data and the complete signal to a native payment app and also how 
it will receive the payment response from the payment app.</p>

@msporny
Copy link
Member Author

msporny commented Mar 30, 2016

@adrianhopebailie wrote:

For consistency, I think the issue markers for issues #50, #39 should follow a similar format as they both relate to payment app interface

Done. Used your language and preference to issue marker location.

@adrianba
Copy link
Contributor

adrianba commented Apr 1, 2016

Merged as 1988c40

@adrianba adrianba closed this Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants