Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reference to issue #50. #84

Closed
wants to merge 3 commits into from
Closed

Add a reference to issue #50. #84

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81b3240
Remove trailing whitespace.
msporny Mar 14, 2016
2ff1406
Add reference to issue #50.
msporny Mar 16, 2016
271b3e7
Update reference to issue #50.
msporny Mar 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions specs/paymentrequest.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,13 @@ <h2>PaymentResponse interface</h2>
};
</pre>

<p class="issue" data-number="50" title="How are payment requests and responses passed between the browser and third-party native wallets?">
How are payment messages routed between the browser and native payment
apps? The spec should give developers some idea of how the integration
might happen via a NOTE or similar mechanism to ensure that people know
it won't be just the OS vendors providing payment apps.
</p>

<p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msporny For consistency, I think the issue markers for issues #50, #39 should follow a similar format as they both relate to payment app interface (one for native apps and the other for web based apps).

I would suggest the following text and would include this at an appropriate point in the section User Agent delegates payment request algorithm and possibly another reference in the complete() section as this refers to messages being passed back to the payment app.

Suggested text:

<p class="issue" data-number="50" title="It is unclear how the user agent will interface with 
a native payment app.">This specification should describe how the user-agent will pass the payment request data and the complete signal to a native payment app and also how 
it will receive the payment response from the payment app.</p>

A <code><dfn>PaymentResponse</dfn></code> is returned when a user has selected a payment method and
approved a payment request. It contains the following fields:
Expand Down