Specify the textInput event #362

zcorpan · 2023-11-24T00:05:29Z

Fixes #353

The following tasks have been completed:

Confirmed there are no ReSpec/BikeShed errors or warnings.
Modified Web platform tests UIEvents: Test the textInput event web-platform-tests/wpt#44472

Implementation commitment:

WebKit (already supported; event order: https://bugs.webkit.org/show_bug.cgi?id=268988)
Chromium (already supported; minor IDL difference: https://issues.chromium.org/u/1/issues/324276564)
Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=903746)

sections/legacy-event-types.txt

zcorpan · 2023-12-05T12:55:18Z

I think fixing #361 first would be nice so that this event can slot in between beforeinput and input in the default action chain.

zcorpan · 2024-01-11T23:21:16Z

I've moved the spec for this into event-algo.bs, since trying to make it well-defined in the current spec was ... challenging.

I think this is ready for review.

event-algo.bs

masayuki-nakano · 2024-01-19T02:48:23Z

And I've not tested when replacing typo word with the spellchecker.

sections/legacy-event-types.txt

masayuki-nakano · 2024-01-29T10:11:02Z

WPt is required at least for:

no constructor
initTextEvent
Document.createEvent and instance of TextEditor and instance of UIEvent with the result.
addEventListener with textInput and textinput
With typing a character (an ASCII character and a non-BMP character)
With deleting a character around caret (no textInput)
With deleting a character with non-collapsed selection (no textInput)
With execCommand("insertText", false, "something") (no textInput)

masayuki-nakano · 2024-01-30T02:06:30Z

Oh? There is no ontextinput nor ontextInput attribute in the global event handler? Chrome does not run the script set to it and there is no property when I check an element with the devtools.

masayuki-nakano · 2024-01-30T02:38:45Z

Hmm, in <input>, Chrome fires beforeinput event but no textInput event when I press Enter...

masayuki-nakano · 2024-01-30T02:52:24Z

When I replace a misspell word on Chrome, Chrome does not fire textInput after beforeinput.

masayuki-nakano · 2024-01-30T05:28:19Z

I wonder, whether textInput should be fired after a beforeinput event listener makes the editing host blurred.

event-algo.bs

masayuki-nakano · 2024-01-31T03:37:47Z

If I call preventDefault of textInput at DnD in same editing host, the deletion is also canceled on Chrome. It's impossible to emulate that on Firefox without adding a lot of hacky code...

And also a call of preventDefault for IME composition cannot cancel the default action but its cancelable is set to true on Chrome.

masayuki-nakano · 2024-01-31T03:41:43Z

I wonder, how about insertFromYank? I don't know whether Chrome and/or Safari support it and how to do that.

zcorpan · 2024-02-02T14:10:56Z

I wonder, whether textInput should be fired after a beforeinput event listener makes the editing host blurred.

Interestingly, Chrome and Safari seem to prevent moving focus while handling beforeinput: http://software.hixie.ch/utilities/js/live-dom-viewer/saved/12339

(Opening a popup works, but still fires the textInput event.)

zcorpan · 2024-02-02T14:25:39Z

I wonder, how about insertFromYank? I don't know whether Chrome and/or Safari support it and how to do that.

I didn't know it was a thing, but I see it in https://w3c.github.io/input-events/ (issue: w3c/input-events#20 ).

Per https://www.howtogeek.com/293850/how-to-use-macos-built-in-kill-and-yank-as-an-alternative-cut-and-paste/ on macOS you can use ctrl+k to kill (cut) and ctrl+y to yank (paste).

Testing in http://software.hixie.ch/utilities/js/live-dom-viewer/saved/12340 , neither Safari or Chrome fire textInput when yanking.

zcorpan · 2024-02-02T14:34:39Z

Hmm, in <input>, Chrome fires beforeinput event but no textInput event when I press Enter...

Should I check if the event target is an HTMLInputElement element in the spec?

masayuki-nakano · 2024-02-07T07:52:38Z

Hmm, in <input>, Chrome fires beforeinput event but no textInput event when I press Enter...

Should I check if the event target is an HTMLInputElement element in the spec?

Yeah, I think so. (Thank you for investigating about yanking!)

See w3c/uievents#362

zcorpan · 2024-02-08T15:02:47Z

WPt is required at least for:

* no constructor

* `initTextEvent`

* `Document.createEvent` and `instance of TextEditor` and `instance of UIEvent` with the result.

* `addEventListener` with `textInput` and `textinput`

* With typing a character (an ASCII character and a non-BMP character)

* With deleting a character around caret (no `textInput`)

* With deleting a character with non-collapsed selection (no `textInput`)

* With `execCommand("insertText", false, "something")` (no `textInput`)

Thanks, tested in web-platform-tests/wpt#44472

I used a smiley for non-BMP character, but I think it's not automatable with WebDriver currently.

zcorpan · 2024-02-08T15:03:49Z

Should I check if the event target is an HTMLInputElement element in the spec?

Done in 7b9b6a5

https://bugs.webkit.org/show_bug.cgi?id=268988 Reviewed by Wenson Hsieh and Ryosuke Niwa. This change makes WebKit fire the beforeinput & textInput events in the order (beforeinput first, textInput after) conforming to UI Events spec requirements at w3c/uievents#362 and in the spec at https://w3c.github.io/uievents/event-algo.html#fire%20key%20input%20events and consistent with the order in which the events are fired in Blink. Otherwise, without this change, WebKit fires the events in an order (textInput first, beforeinput after) that breaks conformance with the spec requirements, and that breaks compatibility with Blink. Note also that this change makes WebKit conform to the requirements in https://w3c.github.io/uievents/event-algo.html#fire%20key%20input%20events, https://w3c.github.io/uievents/event-algo.html#handle%20native%20paste, and https://w3c.github.io/uievents/event-algo.html#end%20composition — limiting textInput to being fired only when ending a composition or when the input type is insertText, insertParagraph, insertLineBreak, or insertFromPaste. * LayoutTests/editing/execCommand/break-out-of-empty-list-item.html: * LayoutTests/editing/inserting/typing-space-to-trigger-smart-link.html: * LayoutTests/editing/pasteboard/paste-text-events-expected.txt: * LayoutTests/editing/pasteboard/paste-text-events.html: * LayoutTests/editing/style/highlight-insert-paragraph.html: * LayoutTests/fast/events/input-events-fired-when-typing-expected.txt: * LayoutTests/fast/events/input-events-fired-when-typing.html: * LayoutTests/fast/events/ios/submit-form-target-blank-using-return-key.html: * LayoutTests/fast/events/onchange-passwordfield.html: * LayoutTests/fast/events/onchange-searchfield.html: * LayoutTests/fast/events/onchange-textfield.html: * LayoutTests/fast/forms/onchange-change-type.html: * LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: * LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt: * LayoutTests/platform/mac-wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: * LayoutTests/platform/wpe/TestExpectations: * Source/WebCore/dom/Node.cpp: (WebCore::Node::defaultEventHandler): * Source/WebCore/dom/TextEvent.cpp: (WebCore::TextEvent::TextEvent): (WebCore::TextEvent::initTextEvent): (WebCore::TextEvent::createForPlainTextPaste): Deleted. (WebCore::TextEvent::createForFragmentPaste): Deleted. (WebCore::TextEvent::createForDictation): Deleted. * Source/WebCore/dom/TextEvent.h: * Source/WebCore/editing/AlternativeTextController.cpp: (WebCore::AlternativeTextController::insertDictatedText): * Source/WebCore/editing/Editor.cpp: (WebCore::dispatchTextInputEvent): (WebCore::Editor::selectionForCommand): (WebCore::Editor::pasteAsPlainText): (WebCore::Editor::pasteAsFragment): (WebCore::dispatchTextInputEvents): (WebCore::Editor::appliedEditing): (WebCore::Editor::insertText): (WebCore::Editor::insertTextForConfirmedComposition): (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::setComposition): (WebCore::Editor::handleTextEvent): Deleted. * Source/WebCore/editing/Editor.h: * Source/WebCore/editing/EditorCommand.cpp: (WebCore::executeInsertBacktab): (WebCore::executeInsertLineBreak): (WebCore::executeInsertNewline): (WebCore::executeInsertTab): (WebCore::executeYank): (WebCore::executeYankAndSelect): (WebCore::enabledVisibleSelection): (WebCore::enabledVisibleSelectionAndMark): (WebCore::enableCaretInEditableText): (WebCore::enabledInEditableText): * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::handleTextInput): (WebCore::EventHandler::handleTextInputEvent): Deleted. (WebCore::EventHandler::defaultTextInputEventHandler): Deleted. * Source/WebCore/page/EventHandler.h: Canonical link: https://commits.webkit.org/278971@main

https://bugs.webkit.org/show_bug.cgi?id=268988 Reviewed by NOBODY (OOPS!). This change (controlled by the ConformantBeforeinputEventFiringOrderEnabled, preference, also introduced in this change) makes WebKit fire the beforeinput and textInput events in the order: beforeinput first, textInput after — conforming to the requirements at w3c/uievents#362 and https://w3c.github.io/uievents/event-algo.html#fire%20key%20input%20events and consistent with the order in which the events are fired in Blink. Otherwise, without this change, WebKit fires the events in the order: textInput first, beforeinput after — which breaks conformance with the spec requirements, and breaks compatibility with Blink. Note also that this change makes WebKit conform to the requirements in https://w3c.github.io/uievents/event-algo.html#fire%20key%20input%20events, https://w3c.github.io/uievents/event-algo.html#handle%20native%20paste, and https://w3c.github.io/uievents/event-algo.html#end%20composition — limiting textInput to being fired only when ending a composition or when the input type is insertText, insertParagraph, insertLineBreak, or insertFromPaste. * LayoutTests/editing/execCommand/break-out-of-empty-list-item.html: * LayoutTests/editing/inserting/typing-space-to-trigger-smart-link.html: * LayoutTests/editing/pasteboard/paste-text-events-expected.txt: * LayoutTests/editing/pasteboard/paste-text-events.html: * LayoutTests/editing/style/highlight-insert-paragraph.html: * LayoutTests/fast/events/input-events-fired-when-typing-expected.txt: * LayoutTests/fast/events/input-events-fired-when-typing-nonconforming-expected.txt: Copied from LayoutTests/fast/events/input-events-fired-when-typing-expected.txt. * LayoutTests/fast/events/input-events-fired-when-typing-nonconforming.html: Copied from LayoutTests/fast/events/input-events-fired-when-typing.html. * LayoutTests/fast/events/input-events-fired-when-typing.html: * LayoutTests/fast/events/ios/submit-form-target-blank-using-return-key-old-code-path-expected.txt: Added. * LayoutTests/fast/events/ios/submit-form-target-blank-using-return-key-old-code-path.html: Added. * LayoutTests/fast/forms/onchange-change-type.html: * LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: * LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/editing/AlternativeTextController.cpp: (WebCore::AlternativeTextController::insertDictatedText): * Source/WebCore/editing/Editor.cpp: (WebCore::dispatchTextInputEvent): (WebCore::Editor::selectionForCommand): (WebCore::Editor::handleTextEvent): (WebCore::Editor::pasteAsPlainText): (WebCore::Editor::pasteAsFragment): (WebCore::dispatchTextInputEvents): (WebCore::Editor::appliedEditing): (WebCore::Editor::insertText): (WebCore::Editor::insertTextForConfirmedComposition): (WebCore::Editor::insertTextWithoutSendingTextEventNew): (WebCore::Editor::insertTextWithoutSendingTextEventOld): (WebCore::Editor::setComposition): (WebCore::Editor::insertTextWithoutSendingTextEvent): Deleted. * Source/WebCore/editing/Editor.h: * Source/WebCore/editing/EditorCommand.cpp: (WebCore::executeInsertBacktab): (WebCore::executeInsertLineBreak): (WebCore::executeInsertNewline): (WebCore::executeInsertTab): (WebCore::executeYank): (WebCore::executeYankAndSelect): (WebCore::enabledVisibleSelection): (WebCore::enabledVisibleSelectionAndMark): (WebCore::enableCaretInEditableText): (WebCore::enabledInEditableText): * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::handleTextInput): * Source/WebCore/page/EventHandler.h:

See w3c/uievents#362 for context.

zcorpan commented Nov 24, 2023

View reviewed changes

sections/legacy-event-types.txt Outdated Show resolved Hide resolved

garykac force-pushed the textInput branch from 80df9c6 to 2919c0c Compare December 4, 2023 22:39

zcorpan marked this pull request as ready for review January 11, 2024 23:17

masayuki-nakano reviewed Jan 19, 2024

View reviewed changes

event-algo.bs Show resolved Hide resolved

masayuki-nakano suggested changes Jan 19, 2024

View reviewed changes

event-algo.bs Show resolved Hide resolved

event-algo.bs Show resolved Hide resolved

event-algo.bs Show resolved Hide resolved

masayuki-nakano reviewed Jan 29, 2024

View reviewed changes

sections/legacy-event-types.txt Outdated Show resolved Hide resolved

This was referenced Jan 29, 2024

Define events for drag-and-drop operations (textInput etc) #367

Open

The textInput event mozilla/standards-positions#975

Closed

masayuki-nakano reviewed Jan 30, 2024

View reviewed changes

event-algo.bs Outdated Show resolved Hide resolved

zcorpan added a commit to whatwg/dom that referenced this pull request Feb 8, 2024

createEvent("textevent") creates a TextEvent

7ec1945

See w3c/uievents#362

zcorpan mentioned this pull request Feb 8, 2024

createEvent("textevent") creates a TextEvent whatwg/dom#1254

Merged

5 tasks

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Feb 8, 2024

UIEvents: Test the textInput event

a53bd11

See w3c/uievents#362

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Feb 8, 2024

UIEvents: Test the textInput event

def4f37

See w3c/uievents#362

zcorpan mentioned this pull request Feb 8, 2024

UIEvents: Test the textInput event web-platform-tests/wpt#44472

Merged

sideshowbarker mentioned this pull request May 22, 2024

The beforeinput event should fire before textInput WebKit/WebKit#28902

Open

vinhill pushed a commit to vinhill/dom that referenced this pull request Jun 20, 2024

createEvent("textevent") creates a TextEvent

134020a

See w3c/uievents#362 for context.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Specify the textInput event #362

Specify the textInput event #362

zcorpan commented Nov 24, 2023 •

edited

Loading

zcorpan commented Dec 5, 2023

zcorpan commented Jan 11, 2024

masayuki-nakano commented Jan 19, 2024

masayuki-nakano commented Jan 29, 2024

masayuki-nakano commented Jan 30, 2024

masayuki-nakano commented Jan 30, 2024

masayuki-nakano commented Jan 30, 2024

masayuki-nakano commented Jan 30, 2024

masayuki-nakano commented Jan 31, 2024

masayuki-nakano commented Jan 31, 2024

zcorpan commented Feb 2, 2024

zcorpan commented Feb 2, 2024

zcorpan commented Feb 2, 2024

masayuki-nakano commented Feb 7, 2024

zcorpan commented Feb 8, 2024

zcorpan commented Feb 8, 2024

Specify the textInput event #362

Specify the textInput event #362

Conversation

zcorpan commented Nov 24, 2023 • edited Loading

zcorpan commented Dec 5, 2023

zcorpan commented Jan 11, 2024

masayuki-nakano commented Jan 19, 2024

masayuki-nakano commented Jan 29, 2024

masayuki-nakano commented Jan 30, 2024

masayuki-nakano commented Jan 30, 2024

masayuki-nakano commented Jan 30, 2024

masayuki-nakano commented Jan 30, 2024

masayuki-nakano commented Jan 31, 2024

masayuki-nakano commented Jan 31, 2024

zcorpan commented Feb 2, 2024

zcorpan commented Feb 2, 2024

zcorpan commented Feb 2, 2024

masayuki-nakano commented Feb 7, 2024

zcorpan commented Feb 8, 2024

zcorpan commented Feb 8, 2024

zcorpan commented Nov 24, 2023 •

edited

Loading