-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIEvents: Test the textInput event #44472
Conversation
The IDL should be imported from the spec after the spec change has landed.
uievents/textInput/support/common.js
Outdated
return rv; | ||
} | ||
|
||
function setSelection(el) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you make setSelection()
take selectionStart
and selectionEnd
as params? Global variables across file boundary are hard to understand. (Oh, but the callers set them as arguments!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I meant to do that. Fixed.
<textarea class=test-el></textarea> | ||
<div contenteditable=true class=test-el></div> | ||
<script> | ||
setup({ explicit_timeout: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, adding a manual test, unfortunately...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as far as I know this isn't automatable in wpt.
(Sorry, I didn't realize #44467) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I think that will be when w3c/webref#1153 is merged and the corresponding automated PR for wpt is merged. (Example of such a PR: #44379 ) |
See w3c/uievents#362