Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIEvents: Test the textInput event #44472

Merged
merged 4 commits into from
Feb 23, 2024
Merged

UIEvents: Test the textInput event #44472

merged 4 commits into from
Feb 23, 2024

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Feb 8, 2024

The IDL should be imported from the spec after the spec change has landed.
return rv;
}

function setSelection(el) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you make setSelection() take selectionStart and selectionEnd as params? Global variables across file boundary are hard to understand. (Oh, but the callers set them as arguments!)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I meant to do that. Fixed.

<textarea class=test-el></textarea>
<div contenteditable=true class=test-el></div>
<script>
setup({ explicit_timeout: true });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, adding a manual test, unfortunately...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as far as I know this isn't automatable in wpt.

@masayuki-nakano
Copy link
Contributor

masayuki-nakano commented Feb 9, 2024

And could you apply this change?
https://phabricator.services.mozilla.com/differential/changeset/?ref=7325979

(Sorry, I didn't realize #44467)

Copy link
Contributor

@masayuki-nakano masayuki-nakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zcorpan
Copy link
Member Author

zcorpan commented Feb 23, 2024

The IDL should be imported from the spec after the spec change has landed.

I think that will be when w3c/webref#1153 is merged and the corresponding automated PR for wpt is merged. (Example of such a PR: #44379 )

@zcorpan zcorpan merged commit 7dcb66e into master Feb 23, 2024
19 checks passed
@zcorpan zcorpan deleted the zcorpan/textInput-2 branch February 23, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants