-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to share files #133
Conversation
Add a `files` member to ShareData dictionary.
@@ -238,6 +248,7 @@ <h3> | |||
</h3> | |||
<pre class="idl"> | |||
dictionary ShareData { | |||
FrozenArray<File> files; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be a sequence
, no? We wouldn't expect a developer to pass in a frozen array (i.e., {files: Object.freeze(filesArray)}
).
FrozenArray<File> files; | |
sequence<File> files; |
@hober, during TPAC you mentioned that this may be of interest to the WebKit community. Would you be the right person to help us with reviewing/designing this extension to web share? |
There's code implementing file sharing now in WebKit trunk, see: https://bugs.webkit.org/show_bug.cgi?id=207491 |
@othermaciej, that's fantastic news! thanks for the update. Were you folks ok with the way |
We've currently implemented more or less what is in the spec. However, it's not too late to change what we have before it ships in a non-preview release. I personally think the change proposed in issue #108 would be an improvement. I think |
Sent a PR to WPT so the corresponding test is no longer be tentative. Filed Gecko bug. I'll see if I, or someone on Mozilla's DOM Team, can find time to implement it. |
@ericwilligers, @mgiuca, this is probably ready to land I think. |
Add a
files
member to ShareData dictionary.@ericwilligers, I tried to add in what is in level 2 to kick off discussion.
For normative changes, the following tasks have been completed:
Implementation commitment: