Extract Credential Record abstraction #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2022
timcappalli
reviewed
Jul 11, 2022
Firstyear
reviewed
Jul 18, 2022
agl
reviewed
Aug 20, 2022
akshayku
approved these changes
Sep 7, 2022
|
On the 2022-09-21 WG call we said to merge this after I'd fixed @agl's review comment, but I'd forgotten there was another unresolved comment thread. That led to a slightly more substantial change, so I'll give @timcappalli an opportunity to re-review before we merge this. |
timcappalli
reviewed
Sep 22, 2022
|
changes lgtm |
|
Thanks @timcappalli (and everyone else)! |
github-actions bot
added a commit
to nsatragno/webauthn
that referenced
this pull request
Sep 28, 2022
SHA: 6c823f1 Reason: push, by @nsatragno Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards resolving #1510 and #1556, but is substantive enough to warrant review on its own. This depends on PR #1771 and is a prerequisite of PR #1774.
I open this as a "draft" PR because it has PR #1771 as its base branch, to isolate the diff to the changes unique to this PR. I will re-target this PR to the main branch before merging.
Preview | Diff