Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve guidance around using UV #1774

Merged
merged 6 commits into from
May 3, 2023
Merged

Improve guidance around using UV #1774

merged 6 commits into from
May 3, 2023

Conversation

emlun
Copy link
Member

@emlun emlun commented Jul 11, 2022 •
edited by pr-preview bot
Loading

Fixes #1510. Fixes #1556. This depends on PR #1771 and #1773.

I open this as a "draft" PR because it has PR #1773 as its base branch, to isolate the diff to the changes unique to this PR. I will re-target this PR to the main branch before merging.

Preview | Diff

@emlun emlun requested a review from Firstyear July 11, 2022 14:33
@emlun emlun self-assigned this Jul 11, 2022
This was referenced Jul 11, 2022
Merged
Merged
timcappalli
timcappalli reviewed Jul 11, 2022
View reviewed changes
index.bs Outdated Show resolved Hide resolved
Firstyear
Firstyear requested changes Jul 11, 2022
View reviewed changes
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@nadalin nadalin added this to the L3-WD-01 milestone Jul 27, 2022
@nadalin nadalin requested a review from akshayku July 27, 2022 19:20
@emlun emlun removed this from the L3-WD-01 milestone Aug 2, 2022
@nadalin nadalin added this to the L3-WD-01 milestone Sep 7, 2022
Base automatically changed from credential-record to main September 22, 2022 16:59
@emlun emlun added the stat:puntable Issue or PR that is candidate to move to a later milestone label Oct 3, 2022
@emlun emlun mentioned this pull request Oct 5, 2022
Closed
@Firstyear Firstyear mentioned this pull request Feb 19, 2023
Closed
Firstyear
Firstyear approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@Firstyear Firstyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will be a really good improvement :)

timcappalli
timcappalli approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

index.bs Outdated Show resolved Hide resolved
@emlun
Copy link
Member Author

emlun commented Mar 8, 2023

2023-03-08 call: It's not only Firefox that (currently) has issues with this - credentials created in iOS and then synced to macOS may have the same issue of not being able to use UV on the second device. I think it's still worth keeping the uvInitialized state piece and note the caveat that UV is only meaningful from the second time, but I'll strip out the recommendation to "promote" userVerification: "preferred" to "required".

@Firstyear
Copy link
Contributor

Yeah, I think we have to as well. There are some other issues on macos that allow the uv to be removed if you have preferred so we can't promote :(

@emlun
Copy link
Member Author

emlun commented Mar 22, 2023

I've removed the instruction to "promote" UV preferred to required, and also reworked the uvInitialized state. The caveat on first-time UV is moved to the uvInitialized definition instead of the RP assertion steps, and now refers to a "trust relationship" instead of implying a "guarantee that the same user is operating the authenticator" (which is not what UV is). The update to uvInitialized is now also more defensive as a result.

@timcappalli
Copy link
Member

Changes in 75e67c4 look good to me.

@emlun emlun marked this pull request as ready for review May 3, 2023 19:21
@emlun emlun merged commit 748eea0 into main May 3, 2023
github-actions bot added a commit that referenced this pull request May 3, 2023
@emlun @github-actions
Merge pull request #1774 from w3c/issue-1510-uv-guidance
90d18a6 
SHA: 748eea0
Reason: push, by emlun

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@emlun emlun deleted the issue-1510-uv-guidance branch May 25, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayku akshayku akshayku approved these changes

@timcappalli timcappalli timcappalli approved these changes

@Firstyear Firstyear Firstyear approved these changes

Assignees

@emlun emlun

Labels
stat:puntable Issue or PR that is candidate to move to a later milestone subtype:rp-ops type:technical
Projects
None yet
Milestone
L3-WD-01
5 participants
@emlun @Firstyear @timcappalli @akshayku @nadalin