Add missing fields in dictionaries for JSON representation #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterKale
approved these changes
Jul 12, 2023
agl
approved these changes
Jul 12, 2023
akshayku
approved these changes
Jul 12, 2023
agl
reviewed
Jul 12, 2023
emlun
approved these changes
Jul 26, 2023
github-actions bot
added a commit
that referenced
this pull request
Aug 16, 2023
SHA: 98214b0 Reason: push, by agl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Progdrasil
added a commit
to 1Password/passkey-rs
that referenced
this pull request
Nov 16, 2023
follows what was added in w3c/webauthn#1920
Progdrasil
added a commit
to 1Password/passkey-rs
that referenced
this pull request
Nov 16, 2023
follows what was added in w3c/webauthn#1920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1918
This pr is re-opened.
Also found that attestationFormats field is missing in PublicKeyCredentialRequestOptionsJSON as well, this issue is also addressed with this pr.
Preview | Diff