Up to date #1
Merged
Up to date #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensionResults() come from?
fix #657: where does return value of PublicKeyCredential.getClientExtensionResults() come from?
This resolves #622. This also changes some display name examples to include non-ASCII characters.
Also added a reference to the list item back in the correct place.
This also redefines "Public Key Credential" to cover private keys, public keys, and assertions, as a willful violation of RFC4949. Credential ID is defined to explicitly include the possibility that it's the encrypted Credential Source.
… IDL This resolves #587. Summary: - Make member `PublicKeyCredentialEntity.name` required - Make member `PublicKeyCredentialUserEntity.id` required - Make member `PublicKeyCredentialUserEntity.displayName` required - Remove algorithm step from _§5.1.3 Create a new credential_ that instructed to throw an exception if any of the above members were missing
Only exclude CredIDs matching the RPID
…r standalone It's just confusing to send the whole `AuthenticatorSelectionCriteria` structure but ignore of forbid 2 of the 3 members. If those additional parameters should be added in the future, that will probably be a breaking change anyway.
Fix #587: Make PublicKeyCredentialEntity members required in IDL
…void bikeshed warning regarding multiple elements with same ID (#790)
* Tpm attestation fields clarifications * added reference to the Standard Attestation Structure table as it is hard to understand the field names without... * added reference for TPMS_CERTIFY_INFO * NitBit: Incorporate comments from Alex, Mike
Biometric Criteria Extension
Fix #668: Recommend RPs to verify UP and UV flags
* Add instructions for passing unknown extensions to authenticators * Applied editorial suggestions by Adam Langley and Jeff Hodges * Add note about possibly implementing pass through under a feature flag
The existing string was not able to express the ternary nature of token binding for a given connection. See referenced bug for discussion. Fixes #798
Switch |tokenBindingId| to a structure.
* Sig Clarification * Sig Clarification 2 * Clarify that ECDSA is ASN.1 DER format * Exception for ECDSA for consistency * Put Signature formats in its own section * typo * Incorporating comments * Incorporating comments-2 * Incorporating comments-3 * Incorporating comments-4 * Json comma issue * Incorporating comments - 6
The current feature detection code will throw a 'ReferenceError', as 'PublicKeyCredential' doesn't exist. Adding 'window.' turns it into a property lookup, which fails gracefully.
…entData (#811) * Remove clientExtensions and authenticatorExtensions from CollectedClientData * Add RP ops steps vaguely instructing to verify extension outputs * Require that no options are present that were not requested * Editorial correction: options -> extensions
* Align makeCredential already registered case with CTAP2 * Add notes and privacy concerns section about distinguishable makeCredential errors * Address @equalsJeffH's review comments
…lts attribute (#810) * Change from getClientExtensionResults function to clientExtensionResults attribute * Remove unnecessary internal slot [[clientExtensionsResults]] * Make a very dense sentence slightly less dense
* Spelling and grammar corrections * Fix a few more a/an errors * Apply <code>...</code> as suggested
merging per @AngeloKai's request * fix proper subset tweak * resolve linking error for AttestationNotPrivateError * resolve linking error: idl ref not found for [[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors) * remove unnecessary commits * accept jeff suggestion * added links to two previous WDs
…n MakePublicKeyCredentialOptions (#840) merging on @AngeloKai's request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.