Group "don't reveal {assistive tech,private browsing}" under a common heading

[gibson042]

---

Preview | Diff

[LeaVerou]

Hi there, thanks for this. I like the change, but the diff makes it very hard to review. Given that there is no reason to order assistive tech before private browsing, could you revert their relative order so the diff actually reflects the real change here? Thanks!

[gibson042]

I do see some value in the reordering, because it keeps the private browsing sections adjacent:

• 2 API Design Across Languages
  • …
  • 2.6 Consider limiting new features to secure contexts
  • 2.7 Don’t expose sensitive information
    • 2.7.1 Don’t reveal use of assistive technologies
    • 2.7.2 Don’t reveal that private browsing mode is engaged
  • 2.8 Consider how your API should behave in private browsing mode
  • 2.9 Require user activation for powerful APIs
  • …

Would it help to review by commit?

• de15b5f introduces the new heading and moves "Don't reveal use of assistive technologies" into it without modifying anything other than the heading level of that section and "Don't reveal that private browsing mode is engaged" (and does so incompletely, which is fixed later).

  -<h3 id="do-not-expose-use-of-assistive-tech">Don't reveal that assistive technologies are being used</h3>
  +<h4 id="do-not-expose-use-of-assistive-tech">Don't reveal that assistive technologies are being used</h3>

  -<h3 id="do-not-expose-use-of-private-browsing-mode">Don't reveal that private browsing mode is engaged</h3>
  +<h4 id="do-not-expose-use-of-private-browsing-mode">Don't reveal that private browsing mode is engaged</h3>

• fda3b54 rewords the title of "Don't reveal use of assistive technologies".

  -<h4 id="do-not-expose-use-of-assistive-tech">Don't reveal that assistive technologies are being used</h3>
  +<h4 id="do-not-expose-use-of-assistive-tech">Don't reveal use of assistive technologies</h3>

• 3c9ffbd fixes the adjusted heading levels.

  -<h4 id="do-not-expose-use-of-assistive-tech">Don't reveal use of assistive technologies</h3>
  +<h4 id="do-not-expose-use-of-assistive-tech">Don't reveal use of assistive technologies</h4>

  -<h4 id="do-not-expose-use-of-private-browsing-mode">Don't reveal that private browsing mode is engaged</h3>
  +<h4 id="do-not-expose-use-of-private-browsing-mode">Don't reveal that private browsing mode is engaged</h4>

[cynthia]

Thank you for the submission - we are actually in the process of removing nested principles and this likely goes against that. See: #392