Add extend to imports #283
Conversation
MarkMcCaskey
added
🎉 enhancement
| @@ -41,7 +41,13 @@ impl IsExport for Export { | |||
| /// } | |||
| /// ``` | |||
| pub struct ImportObject { | |||
| map: Rc<RefCell<HashMap<String, Box<dyn LikeNamespace>>>>, | |||
| map: Rc<RefCell<HashMap<(String, String), Box<dyn IsExport>>>>, | |||
There was a problem hiding this comment.
Main issue with this is that we need to keep imported instances alive. I'm not sure the best way to do this, however.
There was a problem hiding this comment.
Hmm, I'm not familiar enough with the code base yet to understand how this change affects the lifetimes of the Exports. It seems like it should be the same, unless you mean that we were dropping entries by namespace before 🤔
There was a problem hiding this comment.
Yeah, the Box<dyn LikeNamespace> could contain an Instance. When getting a function pointer from an ImportObject, if the Instance isn't maintained in the ImportObject, the function pointer will dangle.
There was a problem hiding this comment.
Hmm, it's possible to use two maps and check both to emulate a global name lookup.
Though, I'm still a bit unclear on the ownership... ImportObjects own Instances and Instances own ImportObjects?
|
Closing this in favor of #286 |
resolves #258 (early draft)