Add extend to imports #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkMcCaskey
added
🎉 enhancement
syrusakbary
requested changes
Mar 24, 2019
lib/runtime-core/src/import.rs
Outdated
| let mut map = self.map.borrow_mut(); | ||
| for (ns, id, exp) in iter.into_iter() { | ||
| if let Some(like_ns) = map.get_mut(&ns) { | ||
| like_ns.maybe_insert(&id, exp).expect(&format!( |
There was a problem hiding this comment.
I don't think we should panic if the imports are overwritten. The same way extend doesn't panic on extending a HashMap.
Closed
syrusakbary
approved these changes
Mar 25, 2019
syrusakbary
approved these changes
Mar 25, 2019
|
bors try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a rewrite of #283 with a focus on simplicity
resolves #258