-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up CI #3353
Speed up CI #3353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we chatted, let's keep xtask/makefile completely separated from the PR.
This PR should mainly focus on improving the speed of CI
d0cf753
to
117484e
Compare
3133e06
to
257477c
Compare
Results:
Best Run: 35 minutes with 8 cores, sccache + GitHub cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit 55a9e1a.
Okay so since the last signoff there were a couple of changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's something clearly wrong with the cache here:
https://github.com/wasmerio/wasmer/actions/runs/3741028179/jobs/6350105848
@syrusakbary Yes, I know, but I can't do anything about it, I just call the GH action with the proper parameters. If R2 decides to lock up, that's not really something I can debug. I can only try to use S3 to compare the reliability against R2. |
I'm currently blocked because I can't create an AWS account because I lost my 2FA access to my bank account. I can get it back, but only after the Dec 25th. Sorry :/ |
Co-authored-by: Syrus Akbary <me@syrusakbary.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add integration tests on the steps defined here making sure that everything works as we laid out? (both for the wasm case and the webc case)
Work in progress PR to get the CI runs to be more manageable
Goals:
[jobs]
to be able to run multiple CI steps in parallel