Implement support for multiple commands in one native executable #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 22, 2022
syrusakbary
reviewed
Jan 4, 2023
syrusakbary
reviewed
Jan 4, 2023
syrusakbary
reviewed
Jan 4, 2023
syrusakbary
reviewed
Jan 4, 2023
This reverts commit 5a9418a.
|
Okay @syrusakbary it seems that the object files generated by |
syrusakbary
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3425.
Fixes #3374.
Fixes #3436.
TODO
Currently we aren't running integration tests on Windows, so this led to problems when debugging, since
I can only re-enable integration tests after #3353 is merged, since that PR will change the CI structure massively (doesn't make sense to re-enable before).
I temporarily enabled linking to
wasmer-headless.aand got the binary size of the exe from 24 MB to 9 MB stripped, but this is causing issues on linux-aarch64 because we currently buildlibwasmer-headless.awith the wrong flags.--precompiled-atomsyntax--precompiled-atomcaching not working with linker (esp.--object-format serializedis causing linker issues)