Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Logcollector test for MacOS #2223

Conversation

MizugorouZ
Copy link
Contributor

Related issue
#2096

Description

Most of these tests were failing because after the merge of #2043, the local internal options weren't set. Now the tests autoconfigure their local internal options.

Package

Version Revision Link
4.3.0 2096.logcollector.testing https://packages-dev.wazuh.com/warehouse/test/4.3/macos/wazuh-agent-4.3.0-2096.logcollector.testing.pkg

Testing

MacOS Agent - tests/integration/test_logcollector

OS Jenkins Notes
PS1 🔴 -

  • 🟢: All pass
  • 🟡: Some warnings
  • 🔴: Some errors/fails
  • 🔵: In progress

@juliamagan juliamagan changed the base branch from master to 2096-logcollector-manager-tests November 16, 2021 08:10
@MizugorouZ
Copy link
Contributor Author

MizugorouZ commented Nov 16, 2021

After researching the failed test, it seems like a problem with FileMonitor which was solved in PR#1721. These tests have been executed in the branch 2096-logcollector-macos-tests-filemonitor, which adds the FileMonitor fix:

OS Jenkins Notes
PS1 🔵 -
PS2 🔵 -
PS3 🔵 -

@mauromalara mauromalara added subteam/qa-earthquake refactor Redesign and implement an existing development/feature labels Nov 24, 2021
@Rebits
Copy link
Member

Rebits commented Nov 24, 2021

24/11/21

This branch still has errors and unnecessary skipped tests. Most of the required changes are implemented in #2222, I suggest closing this branch in order to facilitate the testing process.

@Rebits Rebits closed this Nov 29, 2021
@juliamagan juliamagan deleted the 2096-logcollector-macos-tests branch March 22, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Redesign and implement an existing development/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants