Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS logcollector - Fixes and new tests #2043

Merged
merged 81 commits into from
Oct 27, 2021
Merged

macOS logcollector - Fixes and new tests #2043

merged 81 commits into from
Oct 27, 2021

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented Oct 15, 2021 •
edited
Loading

Related issue
#1480, #1470 , #2022 , #1465, #1481

Description

These PR group the following developments:

All these development have been grouped in this PR in order to accelerate the testing process and to ensure test_macos submodule full-green consistency.

Configuration options

Some tests have not use the actual standard so, in order to launch test_macos submodule is necessary to add the following local_internal_options:

logcollector.debug=2
logcollector.sample_log_length=100

15/10/2021

Package

Version Revision Link
4.3.0 40301 https://packages-dev.wazuh.com/warehouse/test/4.3/macos/wazuh-agent-4.3.0-vr.testing.macos.logcollector.pkg

test_logcollector/test_macos

OS Local Jenkins Notes
PS1 🟢 🟢
PS2 🟢 🟢
PS3 🟢 🟢
  • 🟢: All pass
  • 🟡: Some warnings
  • 🔴: Some errors/fails
  • 🔵: In progress

Tests

  • Proven that tests pass when they have to pass.
  • Proven that tests fail when they have to fail.
  • Python codebase satisfies PEP-8 style style guide. pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.
  • Python codebase is documented following the Google Style for Python docstrings.
  • The test is documented in wazuh-qa/docs.
  • provision_documentation.sh generate the docs without errors.

JcabreraC and others added 30 commits September 21, 2021 11:13
@JcabreraC @nmkoremblum
Added UT for wazuh-logcollector.state in macOS
3123ab0
@JcabreraC @nmkoremblum
Fixed documentation and PEP-8 style
a898b76
@JcabreraC @nmkoremblum
Fixed error messages
de49285
@JcabreraC @nmkoremblum
Fixed test documentation
58579b5
@juliancnn @nmkoremblum
Base test for macos file_status IT development
fd13dc9
@nmkoremblum
Logcollector macOS ULS feature file status IT improved
d293247
@juliancnn @nmkoremblum
file status updating time reduced
f4b9a4a
@juliancnn @nmkoremblum
fixes code style in file_status
36a6fde
@juliancnn @nmkoremblum
Adds the documentation of the file_status_basic IT.
a868163
@juliancnn @nmkoremblum
Adds base macos bad predicate IT
70c966e
@nmkoremblum
test macos file status predicate improved and docu added
06d09dc
@nmkoremblum
logcollector macos-related tests and docu improved
852a2a5
@nmkoremblum
llogcollector macos localfile IT and docu added and some improvements…
af35a25 
… to other ITs
@JcabreraC @nmkoremblum
Fixed test documentation
d8986da
@nmkoremblum
Some fixes added
f63b67c
@nmkoremblum
macos_utils.py moved
0590683
@nmkoremblum
Some fixes added to macos ITs
94a0888
@nmkoremblum
Fix macOS ITs according to new QA standards
aeeeb21
@nmkoremblum
Daemon start and stop and minor improvements added
d6123ce
@nmkoremblum
ITs further fixes and improvements
0a532b2
@snaow
Merge pull request #1476 from wazuh/1463-IT-logcollector-state-for-macos
a6f4514 
Added IT for wazuh-logcollector.state in macOS
@nmkoremblum
New ITs changes requested implemented
66552be
@Rebits
Create tests for monitor log process for macos logcollector format
4e20967
@Rebits
Add test for log process to wazuh_macos_format_basic.yaml
ba90daa
@Rebits
Fix macos log process stop suddely test
8ebf903
@Rebits
Fix service function to search processes
d937e7a
@Rebits
Fix assert error in test_macos_log_process_stop
045c6ff
@Rebits
Rename test_macos_log_process_stop_suddenlly to test_macos_log_proces…
2486bdb 
…s_stop_suddenly
@Rebits
Add macos log process tests documentation
8017058
@Rebits
Modificate macos log process tests to add new checks for macOS Sierra
0f4c100
@Rebits Rebits self-assigned this Oct 15, 2021
@juliamagan
Copy link
Member

juliamagan commented Oct 15, 2021 •
edited
Loading

Package

Version Revision Link
4.3.0 40301 https://packages-dev.wazuh.com/warehouse/test/4.3/rpm/var/wazuh-manager-4.3.0-vr.testing.macos.logcollector.x86_64.rpm
4.3.0 40301 https://packages-dev.wazuh.com/warehouse/test/4.3/macos/wazuh-agent-4.3.0-vr.testing.macos.logcollector.pkg

Testing

test_logcollector/test_macos

OS Local Jenkins Notes
PS1 🟢 🔴 local internal options are not correctly set
PS2 🟢
  • 🟢: All pass
  • 🟡: Some warnings
  • 🔴: Some errors/fails
  • 🔵: In progress

@juliamagan
Copy link
Member

juliamagan commented Oct 18, 2021 •
edited
Loading

Package

Version Revision Link
4.3.0 40301 https://packages-dev.wazuh.com/warehouse/test/4.3/rpm/var/wazuh-manager-4.3.0-vr.testing.macos.logcollector.x86_64.rpm
4.3.0 40301 https://packages-dev.wazuh.com/warehouse/test/4.3/macos/wazuh-agent-4.3.0-vr.testing.macos.logcollector.pkg

Testing

test_logcollector/test_macos

OS Local Jenkins Notes
PS1 🟢 🟢
PS2 🟢 🟢
PS3 🟢 🟢
  • 🟢: All pass
  • 🟡: Some warnings
  • 🔴: Some errors/fails
  • 🔵: In progress

@snaow snaow merged commit 60cf7d4 into master Oct 27, 2021
@snaow snaow deleted the 1329-4.3.0-macOS-logcollector branch October 27, 2021 14:53
This was referenced Oct 27, 2021
Closed
Closed
Closed
Closed
Closed
Closed
@CamiRomero CamiRomero mentioned this pull request Oct 28, 2021
Closed
5 tasks
@juliamagan juliamagan mentioned this pull request Nov 5, 2021
Merged
This was referenced Nov 15, 2021
Merged
Closed
@snaow snaow mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliamagan juliamagan juliamagan approved these changes

Assignees

@Rebits Rebits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Rebits @juliamagan @snaow @JcabreraC @juliancnn @nmkoremblum @spothound @damarisg