-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Angular2 Snippets' package #5482
Conversation
As with the other two packages, #5477 and #5480, what are the differences to the other angular packages? Is it just the angular version? If so, I will only accept one out of the three packages. By default, we operate on first come first serve, so @pjlamb12 would get the pass. @evanplaice and @orizens, please consider contributing to that package or engaging in a discussion if you are unsatisfied with that package's direction. |
my package follows john's papa snippets convention (triggers and actual templates). |
@orizens, I'm not familiar with angular, so I'm afraid you need to elaborate on that. |
@FichteFoll I'm referring to the snippets described in angular.io style guide |
@FichteFoll Here's the 'skinny'. The sudden uptick in interest in submitting a snippets package is due to ngconf, which took place 2 weeks ago. The package I submitted was developed alongside the community style guide before it was absorbed as the 'official' style guide. Ref mgechev/angular2-style-guide/issues/15 The snippets provided by @pjlamb12 and @orizens are reimplementations of John Papa's vscode snippet repository. Which is very useful for users who are just getting started with Angular2. This package provides more extensive API coverage, makes fewer assumptions, and favors breaking the syntax down into smaller more granular code completions wherever possible. I'm not keen on getting into an ego driven pissing contest. If name collision is the issue, I can resubmit my PR under the name Thank you for your time and patience. |
hi. |
If there are two different snippet styles, one for experienced users with more control and one for beginners, that's fine. However, as you already mentioned, @evanplaice, the names are too similar currently. I like @orizens' proposal of adding the names to the packages which is more transparent and offers more information when browsing the package list. As such, I propose the following:
This could also be |
While I don't see how snippets can be that different, and how one can be more along the style guide than the one that is based on the style guide author's own snippets, I have changed the name of my package to "Angular 2 Snippets (John Papa)" as suggested so that this process can move on and be added to package control. #5477 |
@evanplaice ping Also, you'll need to change |
New snippets package.
This PR has been tested and verified via ChannelRepositoryTools