Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Angular2 Snippets' package #5482

Closed
wants to merge 1 commit into from
Closed

Add 'Angular2 Snippets' package #5482

wants to merge 1 commit into from

Conversation

evanplaice
Copy link

New snippets package.

This PR has been tested and verified via ChannelRepositoryTools

@FichteFoll
Copy link
Collaborator

FichteFoll commented May 9, 2016

As with the other two packages, #5477 and #5480, what are the differences to the other angular packages? Is it just the angular version?

If so, I will only accept one out of the three packages. By default, we operate on first come first serve, so @pjlamb12 would get the pass. @evanplaice and @orizens, please consider contributing to that package or engaging in a discussion if you are unsatisfied with that package's direction.

@orizens
Copy link
Contributor

orizens commented May 9, 2016

my package follows john's papa snippets convention (triggers and actual templates).
It is to be displayed in angular.io documentation style guide page.

@FichteFoll
Copy link
Collaborator

@orizens, I'm not familiar with angular, so I'm afraid you need to elaborate on that.

@orizens
Copy link
Contributor

orizens commented May 9, 2016

@FichteFoll I'm referring to the snippets described in angular.io style guide
It follows the standards and recommendations of the angular team.
My repository is in PR for this website

@evanplaice
Copy link
Author

@FichteFoll Here's the 'skinny'. The sudden uptick in interest in submitting a snippets package is due to ngconf, which took place 2 weeks ago.

The package I submitted was developed alongside the community style guide before it was absorbed as the 'official' style guide. Ref mgechev/angular2-style-guide/issues/15

The snippets provided by @pjlamb12 and @orizens are reimplementations of John Papa's vscode snippet repository. Which is very useful for users who are just getting started with Angular2.

This package provides more extensive API coverage, makes fewer assumptions, and favors breaking the syntax down into smaller more granular code completions wherever possible.

I'm not keen on getting into an ego driven pissing contest. If name collision is the issue, I can resubmit my PR under the name ng2-snippets. Package Control already has 2 snippets packages for Angular1 (ie 'AngularJS-Snippets' and ng2-snippets). IMHO, a little variety doesn't hurt. If you agree that this is a reasonable compromise, I'll resubmit the PR with the change.

Thank you for your time and patience.

@orizens
Copy link
Contributor

orizens commented May 19, 2016

hi.
perhaps there's a room for both.
so, actually the package's name should note which style guide it reflects - "john papa" or "minko gechev".

@FichteFoll FichteFoll mentioned this pull request May 21, 2016
@FichteFoll
Copy link
Collaborator

If there are two different snippet styles, one for experienced users with more control and one for beginners, that's fine. However, as you already mentioned, @evanplaice, the names are too similar currently. I like @orizens' proposal of adding the names to the packages which is more transparent and offers more information when browsing the package list.

As such, I propose the following:

  1. Rename this package to Angular2 Snippets (Minko Gechev) (or alternatively ng2-snippets)
  2. Reject @orizens' package since he submitted his later than @pjlamb12.
  3. Rename @pjlamb12's package to Angular2 Snippets (John Papa)

This could also be Angular 2 with a space. Idc about that. Could also add a "style" to the parentheses.

@pjlamb12
Copy link
Contributor

pjlamb12 commented Jun 2, 2016

While I don't see how snippets can be that different, and how one can be more along the style guide than the one that is based on the style guide author's own snippets, I have changed the name of my package to "Angular 2 Snippets (John Papa)" as suggested so that this process can move on and be added to package control. #5477

@FichteFoll
Copy link
Collaborator

FichteFoll commented Jun 27, 2016

@evanplaice ping

Also, you'll need to change "branch": "master" to "tags": true and use tags to create releases and push valid semantic version tags to your repo. As mentioned in the docs, we no longer accepts branch-based releases for new packages.

@FichteFoll FichteFoll added the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label Jun 27, 2016
@wbond wbond closed this Sep 12, 2016
@FichteFoll FichteFoll added timeout A pull request needed changes but was not updated in time (2 weeks after becoming stale) and removed stale The pull request needs to be updated but has not been within the recent past (2 weeks) labels Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
timeout A pull request needed changes but was not updated in time (2 weeks after becoming stale)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants