Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular2-snippets added #5790

Closed
wants to merge 1 commit into from
Closed

Conversation

ozcanzaferayan
Copy link

Created Angular2 Typescript snippets for developing components, services etc.

@FichteFoll
Copy link
Collaborator

Please read through #5482 and conclude which style your snippets follow. If they are of the same style as https://packagecontrol.io/packages/Angular%202%20Snippets%20(John%20Papa), please consider contributing to that instead.

@FichteFoll
Copy link
Collaborator

Actually, it seems your snippets are more specific and include entire blocks as boiler plate. Please use a more specific name for your package.

@wbond
Copy link
Owner

wbond commented Oct 3, 2016

@ozcanzaferayan Do you have any thoughts regarding the comments from FichteFoll?

@ozcanzaferayan
Copy link
Author

I will change package name as angular2-boilerplate

@FichteFoll
Copy link
Collaborator

@ozcanzaferayan please do so

@FichteFoll FichteFoll added the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label Oct 20, 2016
@FichteFoll FichteFoll closed this Nov 6, 2016
@FichteFoll FichteFoll added timeout A pull request needed changes but was not updated in time (2 weeks after becoming stale) and removed stale The pull request needs to be updated but has not been within the recent past (2 weeks) labels Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
timeout A pull request needed changes but was not updated in time (2 weeks after becoming stale)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants