-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make probes use https with Scope Service #777
Comments
I've found that I don't get anything sent to the 2nd host. (or maybe nothing sent at all, I'm not sure if stuff is going to
In the scope service dev UI:
Changing |
I don't see how that's related to this ticket. If it happens in master (and On Tuesday, December 29, 2015, Simon notifications@github.com wrote:
|
The Scope Service now supports https. Thus, the probes should use https instead of http. AFAIU this can be done simply by reverting d57d4aa
While we are at it, it would be good to avoid implicitly including
scope.weave.works
in the probe's targets when--service-token
is provided.For instance, contrary to what the user expects the command
scope launch --service-token=foo my.own.scope.service.com:80
will try to send reports to bothmy.own.scope.service.com:80
andscope.weave.works:80
.The text was updated successfully, but these errors were encountered: