Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make probes use https with Scope Service #777

Closed
2opremio opened this issue Dec 16, 2015 · 2 comments
Closed

Make probes use https with Scope Service #777

2opremio opened this issue Dec 16, 2015 · 2 comments
Milestone

Comments

@2opremio
Copy link
Contributor

The Scope Service now supports https. Thus, the probes should use https instead of http. AFAIU this can be done simply by reverting d57d4aa

While we are at it, it would be good to avoid implicitly including scope.weave.works in the probe's targets when --service-token is provided.

For instance, contrary to what the user expects the command scope launch --service-token=foo my.own.scope.service.com:80 will try to send reports to both my.own.scope.service.com:80 and scope.weave.works:80.

@foot
Copy link
Contributor

foot commented Dec 29, 2015

I've found that I don't get anything sent to the 2nd host. (or maybe nothing sent at all, I'm not sure if stuff is going to scope.weave.works). E.g. Running locally like this:

2632 root 0:00 /home/weave/scope probe -docker=true -token=abc scope.weave.works:80 frontend.dev.weave.works:80

In the scope service dev UI:

  • No new "(connected)" probe in "Configure your app"
  • Nothing to show in scope topo view.

Changing docker/entrypoint.sh so that frontend.dev.weave.works is the only entry works and I get probes in the dev service UI!

@2opremio
Copy link
Contributor Author

I don't see how that's related to this ticket. If it happens in master (and
from your comment I believe it does), it deserves a ticket of its own.

Related to #698 and #630

On Tuesday, December 29, 2015, Simon notifications@github.com wrote:

I've found that I don't get anything sent to the 2nd host. (or maybe
nothing sent at all, I'm not sure if stuff is going to scope.weave.works).
E.g. Running locally like this:

2632 root 0:00 /home/weave/scope probe -docker=true
-token=9s95dcemze1ztbigthubtay9mwxaniws scope.weave.works:80
frontend.dev.weave.works:80

In the scope service dev UI:

  • No new "(connected)" probe in "Configure your app"
  • Nothing to show in scope topo view.

Changing docker/entrypoint.sh as described in weaveworks/service#275
weaveworks/service#275 so that
frontend.dev.weave.works is the only entry works and I get probes in the
dev service UI!


Reply to this email directly or view it on GitHub
#777 (comment).

@tomwilkie tomwilkie added this to the 0.12.0 milestone Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants