-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix probe connected status #275
Conversation
@davkal RFR |
Code looks good. Still need to see it in action. Is it deployed to dev? |
Nope, you can test it w/ the BACKEND_HOST trick:
You can add probes to dev.weave.works by applying this to scope diff --git a/docker/entrypoint.sh b/docker/entrypoint.sh
index b38721d..7f1fea6 100755
--- a/docker/entrypoint.sh
+++ b/docker/entrypoint.sh
@@ -108,7 +108,7 @@ while true; do
shift
fi
PROBE_ARGS="$PROBE_ARGS -token=$ARG_VALUE"
- echo "scope.weave.works:80" >/etc/weave/apps
+ echo "frontend.dev.weave.works:80" >/etc/weave/apps
touch /etc/service/app/down
;;
--no-app) and running
ORRR.... we could deploy this branch to |
weaveworks/scope#777 suggests you shouldn't have to apply that diff and that you can just start w/
|
But the scope |
the code looks good. @2opremio would it be ok if you test it on your next deploy to dev? |
7375bae
to
5c90838
Compare
We take this as probe.lastSeen > 15s.
Server was strangely changing the order they were returned in.
7a3bafd
to
9f6e0fb
Compare
fixes #255