Update weaveworks/common for histogram buckets and logging changes #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would clamp at 10 seconds, giving a misleading impression for things that can take a lot longer to respond.
bboreham
force-pushed
the
bigger-buckets
branch
from
3122a67 to
a07ff8e
Compare
leth
approved these changes
Jan 10, 2018
bboreham
force-pushed
the
bigger-buckets
branch
from
c5450c0 to
608b348
Compare
bboreham
changed the title
|
What is happening with this? |
|
Overtaken by #1742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
weaveworks/commonto include weaveworks/common#81 "Extend histogram buckets for a server up to 100 seconds"Previously we would clamp at 10 seconds, giving a misleading impression for things that can take a lot longer to respond.
Since I updated to latest, this also brings in:
- weaveworks/common#83 "Let servers set any gRPC options they like "
- weaveworks/common#84 "Don't log request body and headers for 502 errors"