Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/#486 #488

Merged
merged 6 commits into from
Sep 11, 2023
Merged

Fix/#486 #488

merged 6 commits into from
Sep 11, 2023

Conversation

tsmith023
Copy link
Contributor

@tsmith023 tsmith023 commented Sep 7, 2023

Fixes #486 by checking whether class_definition["properties"] is not None before performing further schema checks

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 92.00% and project coverage change: -0.55% ⚠️

Comparison is base (eb3bf16) 95.43% compared to head (90786f0) 94.88%.
Report is 146 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   95.43%   94.88%   -0.55%     
==========================================
  Files          64       72       +8     
  Lines        8165     8668     +503     
==========================================
+ Hits         7792     8225     +433     
- Misses        373      443      +70     
Files Changed Coverage Δ
weaviate/util.py 91.01% <72.91%> (-5.32%) ⬇️
weaviate/batch/crud_batch.py 78.11% <75.00%> (-17.21%) ⬇️
weaviate/schema/crud_schema.py 81.98% <80.55%> (+3.82%) ⬆️
weaviate/connect/connection.py 89.30% <83.33%> (+0.36%) ⬆️
weaviate/gql/aggregate.py 82.97% <85.45%> (+7.11%) ⬆️
mock_tests/test_exception.py 87.50% <87.50%> (ø)
weaviate/connect/authentication.py 96.15% <87.50%> (+8.15%) ⬆️
weaviate/exceptions.py 90.69% <87.50%> (-0.74%) ⬇️
weaviate/classification/config_builder.py 98.82% <88.88%> (-1.18%) ⬇️
weaviate/gql/filter.py 93.95% <93.69%> (-0.40%) ⬇️
... and 29 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul
Copy link
Collaborator

dirkkul commented Sep 7, 2023

Let's just remove the schema validation. It always causes problems and doesn't help much

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@tsmith023 tsmith023 merged commit b95ac22 into main Sep 11, 2023
23 of 24 checks passed
@tsmith023 tsmith023 deleted the fix/#486 branch September 11, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SchemaValidationException when updating class with no properties
4 participants