Fix/#486

integration/test_schema.py

@@ -1,6 +1,7 @@
 from typing import Optional
 
 import pytest
+import requests
 
 import weaviate
 from weaviate import Tenant, TenantActivityStatus
@@ -120,6 +121,19 @@ def test_class_tenants(client: weaviate.Client):
     assert len(tenants_get) == 1
 
 
+def test_update_schema_with_no_properties(client: weaviate.Client):
+    single_class = {"class": "NoProperties"}
+
+    requests.post("http://localhost:8080/v1/schema", json=single_class)
+    assert client.schema.exists("NoProperties")
+
+    client.schema.update_config("NoProperties", {"vectorIndexConfig": {"ef": 64}})
+    assert client.schema.exists("NoProperties")
+
+    client.schema.delete_class("NoProperties")
+    assert client.schema.exists("NoProperties") is False
+
+
 def test_class_tenants_activate_deactivate(client: weaviate.Client):
     class_name = "MultiTenancyActivateDeactivateSchemaTest"
     uncap_class_name = "multiTenancyActivateDeactivateSchemaTest"

test/schema/properties/test_properties.py

@@ -6,7 +6,6 @@
 from test.util import mock_connection_func, check_error_message, check_startswith_error_message
 from weaviate.exceptions import (
     UnexpectedStatusCodeException,
-    SchemaValidationException,
 )
 from weaviate.schema.properties import Property
 
@@ -21,18 +20,12 @@ def test_create(self):
 
         # invalid calls
         error_message = "Class name must be of type str but is "
-        check_property_error_message = 'Property does not contain "dataType"'
         requests_error_message = "Property was created properly."
 
         with self.assertRaises(TypeError) as error:
             prop.create(35, {})
         check_error_message(self, error, error_message + str(int))
 
-        # test if `check_property` is called in `create`
-        with self.assertRaises(SchemaValidationException) as error:
-            prop.create("Class", {})
-        check_error_message(self, error, check_property_error_message)
-
         prop = Property(mock_connection_func("post", side_effect=RequestsConnectionError("Test!")))
         with self.assertRaises(RequestsConnectionError) as error:
             prop.create("Class", {"name": "test", "dataType": ["test_type"]})

weaviate/schema/crud_schema.py

@@ -11,8 +11,6 @@
 from weaviate.exceptions import UnexpectedStatusCodeException
 from weaviate.schema.properties import Property
 from weaviate.schema.validate_schema import (
-    validate_schema,
-    check_class,
     CLASS_KEYS,
     PROPERTY_KEYS,
 )
@@ -176,8 +174,6 @@ def create(self, schema: Union[dict, str]) -> None:
         """
 
         loaded_schema = _get_dict_from_object(schema)
-        # validate the schema before loading
-        validate_schema(loaded_schema)
         self._create_classes_with_primitives(loaded_schema["classes"])
         self._create_complex_properties_from_classes(loaded_schema["classes"])
 
@@ -230,8 +226,6 @@ def create_class(self, schema_class: Union[dict, str]) -> None:
         """
 
         loaded_schema_class = _get_dict_from_object(schema_class)
-        # validate the class before loading
-        check_class(loaded_schema_class)
         self._create_class_with_primitives(loaded_schema_class)
         self._create_complex_properties_from_class(loaded_schema_class)
 
@@ -437,7 +431,6 @@ def update_config(self, class_name: str, config: dict) -> None:
         class_name = _capitalize_first_letter(class_name)
         class_schema = self.get(class_name)
         new_class_schema = _update_nested_dict(class_schema, config)
-        check_class(new_class_schema)
 
         path = "/schema/" + class_name
         try:

weaviate/schema/properties/crud_properties.py

@@ -5,7 +5,6 @@
 
 from weaviate.connect import Connection
 from weaviate.exceptions import UnexpectedStatusCodeException
-from weaviate.schema.validate_schema import check_property
 from weaviate.util import _get_dict_from_object, _capitalize_first_letter
 
 
@@ -66,9 +65,6 @@ def create(self, schema_class_name: str, schema_property: dict) -> None:
 
         loaded_schema_property = _get_dict_from_object(schema_property)
 
-        # check if valid property
-        check_property(loaded_schema_property)
-
         schema_class_name = _capitalize_first_letter(schema_class_name)
 
         path = f"/schema/{schema_class_name}/properties"

weaviate/schema/validate_schema.py

@@ -97,9 +97,10 @@ def check_class(class_definition: dict) -> None:
         ]:
             _check_key_type(key, class_definition[key], dict)
         if key in ["properties"]:
-            _check_key_type(key, class_definition[key], list)
+            if (properties := class_definition[key]) is not None:
+                _check_key_type(key, properties, list)
 
-    if "properties" in class_definition:
+    if "properties" in class_definition and class_definition["properties"] is not None:
         for class_property in class_definition["properties"]:
             check_property(class_property)