RFC 106: Move wpt.fyi metrics generation into the WPT org #106
Conversation
foolip
changed the title
foolip
changed the title
| - Compat 2021 | ||
| - Interop 2022 | ||
|
|
||
| wpt-results-analysis depends on wpt-results, a highly compressed form of all full wpt.fyi runs ever, currently ~52k stored in a ~385M Git repository. This makes it possible to load thousands (or all) runs into memory at the same time, speeding up metrics generation. |
There was a problem hiding this comment.
Can we rename wpt-results, as I think we don't want people thinking it's a canonical data-source? I'm much happier with making everyone treat wpt.fyi's API as the canonical source, and treat wpt-results as an internal implementation detail of result-analysis. Maybe wpt-results-analysis-cache?
There was a problem hiding this comment.
wpt-results-analysis-cache sounds good to me.
Ideally wpt.fyi itself would maintain a representation of results that can be efficiently queried, but that's would be a large undertaking.
|
|
||
| ## Alternatives | ||
|
|
||
| We could merge the metrics generation code into the wpt.fyi repository, but the wpt-results would still need to be standalone. |
There was a problem hiding this comment.
This would put us in an odd state whereby we had wpt.fyi generating CSV files, saving them in its own repo, then wpt.fyi pulling those CSV files, right?
In a sense, having wpt.fyi owning this data makes a lot of sense (it is, ultimately, just another projection of data it already owns), but doing it via CSV files in the repo feels a bit odd.
There was a problem hiding this comment.
I'd like to upload the data files to a storage bucket instead. That's complicated because of GCP rules around exporting service account keys, but we can probably make it work some way or another. It's weird that wpt.fyi fetching data from https://raw.githubusercontent.com/...
|
More than two weeks have passed, so I consider this RFC accepted. When it comes to implementing this, I wanted to name it just "results-analysis", but discovered we already have https://github.com/web-platform-tests/results-analysis as an archived repo. So I'd like to:
An upside of this is that it'll make the transition a bit easier, since both repos will exist, so switching GitHub pages can be done much more easily. |
This merges in Ecosystem-Infra/wpt-results-analysis@7db3a55 which is an unrelated history, to preserve the history from that repo. This implements web-platform-tests/rfcs#106.
|
This is done now:
Because the old repo still exists, as a side effect, the metrics on wpt.fyi will not change until web-platform-tests/wpt.fyi#2799 is merged and deployed. |
It feels slightly unfortunate that it didn't just get moved, thereby meaning all the old issues/PRs are in this old archived repo and links in commit messages don't work. The only upside given here is that it mitigates the GitHub Pages breakage from this, which could equally have been mitigated in other ways (e.g., reuploading a mirror to Ecosystem-Infra to maintain the Pages URLs there, at least in the short term). |
Ah, I didn't consider that option, that probably would have worked, with at most a small amount of downtime. I agree that would have been better. |
Rendered