-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 106: Move wpt.fyi metrics generation into the WPT org #106
Changes from 4 commits
8f3650d
7a3d228
5b30f89
d84df8b
7b57a54
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# RFC 106: Move wpt.fyi metrics generation into the WPT org | ||
|
||
## Summary | ||
|
||
Move https://github.com/Ecosystem-Infra/wpt-results and https://github.com/Ecosystem-Infra/wpt-results-analysis into the web-platform-tests GitHub org. | ||
|
||
## Details | ||
|
||
The following metrics on wpt.fyi are generated by wpt-results-analysis: | ||
|
||
- Browser Specific Failures | ||
- Compat 2021 | ||
- Interop 2022 | ||
|
||
wpt-results-analysis depends on wpt-results, a highly compressed form of all full wpt.fyi runs ever, currently ~52k stored in a ~385M Git repository. This makes it possible to load thousands (or all) runs into memory at the same time, speeding up metrics generation. | ||
|
||
## Risks | ||
|
||
wpt-results-analysis depends on nodegit, which only works on Node.js 14, see https://github.com/nodegit/nodegit/issues/1840. | ||
|
||
## Alternatives | ||
|
||
We could merge the metrics generation code into the wpt.fyi repository, but the wpt-results would still need to be standalone. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This would put us in an odd state whereby we had wpt.fyi generating CSV files, saving them in its own repo, then wpt.fyi pulling those CSV files, right? In a sense, having wpt.fyi owning this data makes a lot of sense (it is, ultimately, just another projection of data it already owns), but doing it via CSV files in the repo feels a bit odd. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd like to upload the data files to a storage bucket instead. That's complicated because of GCP rules around exporting service account keys, but we can probably make it work some way or another. It's weird that wpt.fyi fetching data from https://raw.githubusercontent.com/... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename
wpt-results
, as I think we don't want people thinking it's a canonical data-source? I'm much happier with making everyone treat wpt.fyi's API as the canonical source, and treat wpt-results as an internal implementation detail of result-analysis. Maybewpt-results-analysis-cache
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wpt-results-analysis-cache
sounds good to me.Ideally wpt.fyi itself would maintain a representation of results that can be efficiently queried, but that's would be a large undertaking.