Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node.js (fixes #3144) #3161

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Add support for Node.js (fixes #3144) #3161

merged 1 commit into from
Feb 16, 2023

Conversation

past
Copy link
Member

@past past commented Feb 14, 2023

Adds support for Node.js as a browser/product, which was requested in #3144.

@past past requested a review from KyleJu February 15, 2023 00:07
shared/browsers_test.go Outdated Show resolved Hide resolved
@past past linked an issue Feb 15, 2023 that may be closed by this pull request
@past past self-assigned this Feb 15, 2023
@past
Copy link
Member Author

past commented Feb 16, 2023

Fixed the icon issue by changing the product name from nodejs to node.js. Also removed a spurious package change for growl.

@past past merged commit 5af1ea3 into main Feb 16, 2023
@past past deleted the past/add-nodejs branch February 16, 2023 00:09
@tcl3 tcl3 mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js test runner registration request
3 participants