Add "WebKit" as a product

[gsnedders]

This largely mimics what was done in #3161; let me know if I've missed anything.

[gsnedders]

Also: does it still require any work on the admin side to add things to the backend?

[gsnedders]

That said, we might want to call this "macOS WebKit" (or similar) given how naming is going for Chrome (see also #3214).

[past]

The changes look good to me and I agree that "macOS WebKit" would be better. If you have sorted out the authentication stuff for uploading results, I don't think you need anything else on the backend side.

[KyleJu]

LGTM after addressing the naming!

[DanielRyanSmith]

It looks like there is a test that needs to be updated in components/test/test-search.html

[gsnedders]

Seemingly:

    test('browser test status eq', () => {
      // All known browsers.
      for (const browser of AllBrowserNames) {
        assertQueryParse(browser + ':ok', {exists: [{product: browser, status: 'OK'}]});
      }

My guess is that webapp/components/test-search.js isn't coping with having one browser name be a prefix of another.

Does anyone still around here understand Ohm well enough to quickly know the solution here?

[KyleJu]

CI passed. Merging!

[gsnedders]

LGTM after addressing the naming!

We never did address this! But it sounded like you were hoping to make progress on #3214 soonish?

[KyleJu]

macOS WebKit

We never did address this! But it sounded like you were hoping to make progress on #3214 soonish?

That is my bad! We do intend to address it in Q2, but the renaming should be done in this PR. Would you mind sending a follow-up PR?