Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infrastructure/reftest/size-ref.html flaky on Azure/Edge #15159

Closed
foolip opened this issue Jan 30, 2019 · 8 comments
Closed

infrastructure/reftest/size-ref.html flaky on Azure/Edge #15159

foolip opened this issue Jan 30, 2019 · 8 comments
Assignees
@gsnedders
Labels
Azure Pipelines infra priority:backlog

Comments

@foolip
Copy link
Member

foolip commented Jan 30, 2019

In https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=5357 (before #14300 was landed) /infrastructure/reftest/size-ref.html failed.

https://gist.github.com/foolip/d4b8dc5e236ebcf0cf10b28bf50684da is the edge.tbpl.log.

Pasting that into https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml reveals that the output was "innerWidth x innerHeight: 600x601" instead of the expected "innerWidth x innerHeight: 600x600":
download

The size of this image is also 600x601.
@foolip
Copy link
Member Author

foolip commented Feb 1, 2019

Interesting, this might be flaky.

In https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=5605 for #15196 the test unexpectedly passed.

@foolip foolip mentioned this issue Feb 1, 2019
Merged
@gsnedders
Copy link
Member

It's not that surprising, resizing is a bit weird and complicated and OS dependent to start with, especially if we're dealing with anything where there isn't an integral scaling factor (though I'd be surprised if this were the case for what we're running on Azure?).

@gsnedders
Copy link
Member

One thing that might be worth trying is moving the window to some constant location before we start trying to resize it?

gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Feb 2, 2019
@gsnedders
Try and improve web-platform-tests#15159 by moving the window to a de…
370b12c 
…terministic location

Especially on systems where we don't have an integral scaling factor
between CSS pixels and device pixels we can end up with our ability to
resize the window depending on the location of the window.
@gsnedders gsnedders mentioned this issue Feb 2, 2019
Merged
jgraham pushed a commit that referenced this issue Feb 5, 2019
@gsnedders @jgraham
Try and improve #15159 by moving the window to a deterministic location
71a17e2 
Especially on systems where we don't have an integral scaling factor
between CSS pixels and device pixels we can end up with our ability to
resize the window depending on the location of the window.
@gsnedders
Copy link
Member

@foolip is there any way to just trigger a large number of runs now and see if it's at all stable?

@foolip
Copy link
Member Author

foolip commented Feb 6, 2019

Sure, you can push a branch that uses parallel jobs like all_edge but each does the same steps.

@gsnedders
Copy link
Member

@foolip do you know if this flakiness went away after the above PR?

@gsnedders gsnedders mentioned this issue Mar 7, 2019
Merged
@foolip
Copy link
Member Author

foolip commented Mar 15, 2019

@gsnedders no, I haven't checked.

@gsnedders gsnedders changed the title infrastructure/reftest/size-ref.html fails with edge_webdriver infrastructure/reftest/size-ref.html flaky on Azure/Edge Apr 1, 2019
@foolip
Copy link
Member Author

foolip commented Sep 4, 2019

We're no longer running this configuration.

@foolip foolip closed this as completed Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsnedders gsnedders

Labels
Azure Pipelines infra priority:backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsnedders @foolip