-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two SPC tests fail on Chrome/Edge with flaky webdriver error #33690
Comments
stephenmcgruer
changed the title
Two SPC tests fail with flaky (?) webdriver error
Two SPC tests fail with flaky webdriver error
Apr 19, 2022
stephenmcgruer
changed the title
Two SPC tests fail with flaky webdriver error
Two SPC tests fail on Chrome/Edge with flaky webdriver error
Apr 19, 2022
stephenmcgruer
added a commit
that referenced
this issue
Jun 23, 2022
It turns out that these tests were accidentally responding to postMessages sent by testdriver (instead of the ones sent by the test), and deleting the iframe whilst it was still in use - which then caused webdriver errors. Fix this by adding an explicit tag on the SPC-related messages and filtering for that. This did expose another issue, which is that bless() seems not to be working reliably (at all?) inside an iframe. Fixes #33690
stephenmcgruer
added a commit
that referenced
this issue
Jun 23, 2022
stephenmcgruer
added a commit
that referenced
this issue
Jun 23, 2022
It turns out that these tests were accidentally responding to postMessages sent by testdriver (instead of the ones sent by the test), and deleting the iframe whilst it was still in use - which then caused webdriver errors. Fix this by adding an explicit tag on the SPC-related messages and filtering for that. This did expose another issue, which is that bless() seems not to be working reliably (at all?) inside an iframe. Fixes #33690
(Turns out to be user-error, #34559 has the fix) |
stephenmcgruer
added a commit
that referenced
this issue
Jun 24, 2022
It turns out that these tests were accidentally responding to postMessages sent by testdriver (instead of the ones sent by the test), and deleting the iframe whilst it was still in use - which then caused webdriver errors. Fix this by adding an explicit tag on the SPC-related messages and filtering for that. This did expose another issue, which is that bless() seems not to be working reliably (at all?) inside an iframe. Fixes #33690
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Jun 29, 2022
…ssage handling, a=testonly Automatic update from web-platform-tests [SPC] Avoid trampling on testdriver's message handling (#34559) It turns out that these tests were accidentally responding to postMessages sent by testdriver (instead of the ones sent by the test), and deleting the iframe whilst it was still in use - which then caused webdriver errors. Fix this by adding an explicit tag on the SPC-related messages and filtering for that. This did expose another issue, which is that bless() seems not to be working reliably (at all?) inside an iframe. Fixes web-platform-tests/wpt#33690 -- wpt-commits: 7fd13d47948ccfd5015ff50f3c9a772383c5673c wpt-pr: 34559
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this issue
Jun 30, 2022
…ssage handling, a=testonly Automatic update from web-platform-tests [SPC] Avoid trampling on testdriver's message handling (#34559) It turns out that these tests were accidentally responding to postMessages sent by testdriver (instead of the ones sent by the test), and deleting the iframe whilst it was still in use - which then caused webdriver errors. Fix this by adding an explicit tag on the SPC-related messages and filtering for that. This did expose another issue, which is that bless() seems not to be working reliably (at all?) inside an iframe. Fixes web-platform-tests/wpt#33690 -- wpt-commits: 7fd13d47948ccfd5015ff50f3c9a772383c5673c wpt-pr: 34559
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From https://wpt.fyi/results/secure-payment-confirmation?label=experimental&label=master&aligned, both authentication-cross-origin.sub.https.html and enrollment-in-iframe.sub.https.html flaky-fail with an ERROR from webdriver:
Initial investigation from @KyleJu implied that it started failing on April 8th - https://wpt.fyi/results/secure-payment-confirmation?q=authentication-cross-origin.sub.https.html&run_id=5633278756257792&run_id=5714671674851328
I'm able to reproduce locally on my MacOS device with a Chrome Dev run.
I tried looking for other tests failing this way, but have been unable to find any, so perhaps the tests are doing something unsupported? They both use a temporary cross-origin iframe to do credential enrollment, hosting
https://{{hosts[alt][]}}:{{ports[https][0]}}/secure-payment-confirmation/resources/iframe-enroll.html
(and are the only users of that file I believe).The text was updated successfully, but these errors were encountered: