Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPC] Fix createCredentialForAltDomain #34508

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Conversation

stephenmcgruer
Copy link
Contributor

This was accidentally broken in 00f9369, but went unnoticed due to
issue #33690 . Fixing the method 'fixes' the test
authentication-cross-origin.sub.https.html, though it still fails due to
the underlying issue #33690

This was accidentally broken in 00f9369, but went unnoticed due to
issue #33690 . Fixing the method 'fixes' the test
authentication-cross-origin.sub.https.html, though it still fails due to
the underlying issue #33690
@stephenmcgruer
Copy link
Contributor Author

@rsolomakhin - ping for review :)

@stephenmcgruer stephenmcgruer merged commit 70113ca into master Jun 23, 2022
@stephenmcgruer stephenmcgruer deleted the smcgruer/fix-spc-test branch June 23, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants