Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for URL issue 348 #11389

Merged

Conversation

achristensen07
Copy link
Contributor

No description provided.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing tests too! This looks good to me, but I'll let @domenic verify per usual.

@annevk annevk merged commit 0e084a9 into web-platform-tests:master Jun 8, 2018
@annevk
Copy link
Member

annevk commented Jun 8, 2018

Decided to land this anyway given that @achristensen07 did all the work required and it's a trivial enough change.

annevk pushed a commit to whatwg/url that referenced this pull request Jun 8, 2018
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite right.

"input": "notspecial://host/?'",
"base": "about:blank",
"href": "notspecial://host/?'",
"origin": "notspecial://host",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

origin should be "null"

@annevk
Copy link
Member

annevk commented Jun 8, 2018

Sigh, I should learn to wait.

@annevk
Copy link
Member

annevk commented Jun 8, 2018

I'll post a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants