percent-encode ' in queries of URLs with special schemes #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
approved these changes
Jun 7, 2018
There was a problem hiding this comment.
Thanks for the fix!
It seems this makes query behavior closer to the application/x-www-form-urlencoded format and therefore URLSearchParams.
Could you file a bug against Edge at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/ since it seems to not do this? Used https://jsdom.github.io/whatwg-url/#url=aHR0cHM6Ly9leGFtcGxlLmNvbS8/Jw==&base=YWJvdXQ6Ymxhbms= to test it.
annevk
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 8, 2018
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Jun 8, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 4, 2018
Automatic update from web-platform-testsURL: test ' in queries For whatwg/url#395. -- wpt-commits: 0e084a927078d434bcc1952a2ab99fb541f2c25d wpt-pr: 11389
mcmanus
pushed a commit
to mcmanus/gecko
that referenced
this pull request
Jul 5, 2018
Automatic update from web-platform-testsURL: test ' in queries For whatwg/url#395. -- wpt-commits: 0e084a927078d434bcc1952a2ab99fb541f2c25d wpt-pr: 11389
rmisev
added a commit
to upa-url/upa
that referenced
this pull request
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: web-platform-tests/wpt#11389
Fixes #348
Preview | Diff