WebDriver: fix expected key code for 'Unidentified' keys. #12013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the UI Events specification (https://w3c.github.io/uievents-code/#key-legacy), keys such as \u00e0 (i.e., à) should have a code of "Unidentified". Some tests in key.py expect an empty value, which seems to be an oversight.
wpt-pr-bot
requested review from
andreastt,
AutomatedTester,
mjzffr,
shs96c and
whimboo
|
I don't quite understand this CI failure. Did Chrome previously pass these tests? ERROR:/home/travis/build/web-platform-tests/wpt/tools/ci:| |
|
The CI failure is a bug in the harness that makes it look like Chrome gets multiple results for tests it fails. If this PR is still valid I can merge it. |
|
The PR would need an update given that the tests have been relocated and refactored. |
|
@burg Do you want to have a stab at updating the PR? I think it’s a worthwhile fix to have. |
|
Rebased in #14415. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the UI Events specification (https://w3c.github.io/uievents-code/#key-legacy),
keys such as \u00e0 (i.e., à) should have a code of "Unidentified". Some tests in
key.py expect an empty value, which seems to be an oversight.