webdriver: fix expected key code for "Unidentified" keys #14415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let’s see how the CI fares this time around. |
|
This PR is blocked on the required "Travis CI - Pull Request" check after #14499. In order to trigger it, I will close and reopen this PR. |
|
Shouldn't we also update the WebDriver spec? As it looks like the only appearance of "Unidentified" is currently for |
|
@andreastt can you please check my last comment? |
|
Yes, probably if it’s not there already. This is really a question for @burg, since I just rebased his original PR. |
|
@jgraham would you mind having a look at this PR? In our implementation for Firefox we also still fallback to an empty string. |
Per the UI Events specification (https://w3c.github.io/uievents-code/#key-legacy), keys such as \u00e0 (i.e., à) should have a code of "Unidentified". Some tests in key.py expect an empty value, which seems to be an oversight.
whimboo
force-pushed
the
bburg-unidentified-keys
branch
from
0c61d8d to
7e5d396
Compare
|
@jgraham all the webdriver tests are passing which is interesting. Maybe I miss something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the UI Events specification
(https://w3c.github.io/uievents-code/#key-legacy), keys such as
\u00e0 (i.e., à) should have a code of "Unidentified". Some tests
in key.py expect an empty value, which seems to be an oversight.
This PR supersedes #12013.