Add reftests for vector effects #12712
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AmeliaBR,
ewilligers,
heycam,
nikosandronikos and
svgeesus
svgeesus
requested changes
Sep 8, 2018
There was a problem hiding this comment.
Thanks for producing these.
In terms of the metadata, the reviewer links are not used anymore (because we use GitHub for reviewing) so should preferably be removed. More importantly the reference files should not have rel=help links. Please remove them.
In terms of the tested functionality, this looks correct to me.
Oh and Travis is complaining about tabs instead of spaces, and trailing whitespace on some lines. I know, it seems trivial, but please fix this so the build system does not produce errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.