These are reftests of vector effects of svg 2 other than non scaling stroke. #13302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AmeliaBR,
ewilligers,
heycam,
nikosandronikos and
svgeesus
svgeesus
requested changes
Nov 13, 2018
| <html:link rel="help" | ||
| href="https://svgwg.org/svg2-draft/coords.html#VectorEffects"/> | ||
| <html:link rel="match" href="ve-fixedPosition1-ref.svg" /> | ||
| <metadata class="flags">TOKENS</metadata> |
There was a problem hiding this comment.
Suggested change
| <metadata class="flags">TOKENS</metadata> | |
Either use specific tokens for the flags or, if none are needed, remove the metadata element
| href="https://svgwg.org/svg2-draft/coords.html#VectorEffects"/> | ||
| <html:link rel="match" href="ve-fixedPosition1-ref.svg" /> | ||
| <metadata class="flags">TOKENS</metadata> | ||
| <desc class="assert">TEST ASSERTION</desc> |
There was a problem hiding this comment.
Similarly, either remove the assertion or (better) describe in prose what specifically each test is testing. In this case the title is pretty descriptive so I would just remove the assertion.
svgeesus
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request that solved issues pointed out on #12712