-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-rhythm] Inheritance, initial values #13572
Merged
ewilligers
merged 3 commits into
web-platform-tests:master
from
ewilligers:rhythm-inheritance
May 6, 2019
Merged
[css-rhythm] Inheritance, initial values #13572
ewilligers
merged 3 commits into
web-platform-tests:master
from
ewilligers:rhythm-inheritance
May 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properties inherit or not according to the spec. Properties have initial values according to the spec. https://drafts.csswg.org/css-rhythm/#property-index
@kojiishi please review |
This was referenced Jan 9, 2019
ewilligers
pushed a commit
to ewilligers/csswg-drafts
that referenced
this pull request
May 6, 2019
line-height-step is a length, so the initial value is '0px', not '0'. WPT: web-platform-tests/wpt#13572
kojiishi
approved these changes
May 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you split block and line to separate tests? We haven't heard anyone interested in block property yet, unfortunately.
kojiishi
pushed a commit
to w3c/csswg-drafts
that referenced
this pull request
May 6, 2019
line-height-step is a length, so the initial value is '0px', not '0'. WPT: web-platform-tests/wpt#13572
We can omit the properties that lack implementation, no problem. |
loly89
pushed a commit
to loly89/wpt
that referenced
this pull request
May 6, 2019
* [css-rhythm] Inheritance, initial values Properties inherit or not according to the spec. Properties have initial values according to the spec. https://drafts.csswg.org/css-rhythm/#property-index * line-height-step inherits * Skip unimplemented properties
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
* [css-rhythm] Inheritance, initial values Properties inherit or not according to the spec. Properties have initial values according to the spec. https://drafts.csswg.org/css-rhythm/#property-index * line-height-step inherits * Skip unimplemented properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties inherit or not according to the spec.
Properties have initial values according to the spec.
https://drafts.csswg.org/css-rhythm/#property-index