Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-rhythm] Inheritance, initial values #13572

Merged
merged 3 commits into from
May 6, 2019

Conversation

ewilligers
Copy link
Contributor

Properties inherit or not according to the spec.
Properties have initial values according to the spec.
https://drafts.csswg.org/css-rhythm/#property-index

Properties inherit or not according to the spec.
Properties have initial values according to the spec.
https://drafts.csswg.org/css-rhythm/#property-index
@ewilligers
Copy link
Contributor Author

@kojiishi please review

ewilligers pushed a commit to ewilligers/csswg-drafts that referenced this pull request May 6, 2019
line-height-step is a length, so the initial
value is '0px', not '0'.

WPT: web-platform-tests/wpt#13572
Copy link
Contributor

@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split block and line to separate tests? We haven't heard anyone interested in block property yet, unfortunately.

kojiishi pushed a commit to w3c/csswg-drafts that referenced this pull request May 6, 2019
line-height-step is a length, so the initial
value is '0px', not '0'.

WPT: web-platform-tests/wpt#13572
@ewilligers
Copy link
Contributor Author

We can omit the properties that lack implementation, no problem.

@ewilligers ewilligers merged commit 06e1dff into web-platform-tests:master May 6, 2019
@ewilligers ewilligers deleted the rhythm-inheritance branch May 6, 2019 04:45
loly89 pushed a commit to loly89/wpt that referenced this pull request May 6, 2019
* [css-rhythm] Inheritance, initial values

Properties inherit or not according to the spec.
Properties have initial values according to the spec.
https://drafts.csswg.org/css-rhythm/#property-index

* line-height-step inherits

* Skip unimplemented properties
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
* [css-rhythm] Inheritance, initial values

Properties inherit or not according to the spec.
Properties have initial values according to the spec.
https://drafts.csswg.org/css-rhythm/#property-index

* line-height-step inherits

* Skip unimplemented properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants