[css-scroll-snap] Parsing some scroll-padding* #14787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that scroll-padding-* accept auto and accept postive length-percentage. Not yet tested: negative values, invalid values. https://drafts.csswg.org/css-scroll-snap-1/#property-index
fantasai
reviewed
Jan 10, 2019
There was a problem hiding this comment.
Some comments:
- calc() values for padding should include a percentage, to ensure that length/percentage combinations are parsed
- Might consider pulling in the full set of tests for each set of longhands (physical, logical) into one file: it's still understandable, but also less work for the test runners to execute.
- When you get around to invalid tests, include a calc() with 'auto' inside it.
Otherwise looks good!
Consolidate longhand tests into the shorthand parsing test files.
fantasai
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that scroll-padding-* accept auto
and accept postive length-percentage.
Not yet tested: negative values, invalid values.
https://drafts.csswg.org/css-scroll-snap-1/#property-index