Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-scrollbars] Inheritance, initial values #13647

Merged

Conversation

ewilligers
Copy link
Contributor

Properties inherit or not according to the spec.
Properties have initial values according to the spec.
https://drafts.csswg.org/css-scrollbars/#property-index

@ewilligers
Copy link
Contributor Author

The inheritance tests were failing in Firefox when
scrollbar-color was light and scrollbar-width was 10px.

Changed the values used for inheritance testing, to allow the
inheritance tests to pass with the current Firefox implementation.

(The scrollbar-color initial value test still fails in Firefox.)

@upsuper
Copy link
Member

upsuper commented Oct 23, 2018

It probably shouldn't test scrollbar-color initial value, because I consider it be following "A resolved value special case property like color defined in another specification" so the resolved value should be used value.

It's not completely clear whether it's what we want, though... Actually having auto resolved to auto is easier to implement than the current approach, to be honest.

@upsuper
Copy link
Member

upsuper commented Oct 23, 2018

Filed w3c/csswg-drafts#3237 for that.

@upsuper
Copy link
Member

upsuper commented Oct 24, 2018

The latest nightly should pass all tests here now.

@ewilligers
Copy link
Contributor Author

The spec is clear that auto is the expected computed value for scrollbar-color initial value:

Initial: auto

Computed value: keyword or two computed colors

If this property computes to value other than auto

@tantek Please review.

@upsuper
Copy link
Member

upsuper commented Oct 25, 2018

But the result of gCS is resolved value, which is not necessarily computed value. Anyway the group has resolved on have keywords keep being keywords in resolved value.

@ewilligers
Copy link
Contributor Author

But the result of gCS is resolved value, which is not necessarily computed value.

Thanks. I made the same mistake with caret-color and outline-color tests. Fixing those in
PR 13748

@ewilligers ewilligers force-pushed the scrollbars-inheritance branch from 042d09c to 8ad7a42 Compare May 6, 2019 03:48
@wpt-pr-bot wpt-pr-bot requested a review from upsuper May 6, 2019 03:48
Properties inherit or not according to the spec.
Properties have initial values according to the spec.
https://drafts.csswg.org/css-scrollbars/#property-index
@ewilligers ewilligers force-pushed the scrollbars-inheritance branch from 8ad7a42 to 406f7d1 Compare May 6, 2019 03:51
@ewilligers
Copy link
Contributor Author

@upsuper Please review. I have updated the commit message so it no longer mentions Firefox.

Copy link
Member

@upsuper upsuper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. auto should work now given the resolution a while back.

@ewilligers ewilligers merged commit 5bea989 into web-platform-tests:master May 6, 2019
@ewilligers ewilligers deleted the scrollbars-inheritance branch May 6, 2019 11:56
loly89 pushed a commit to loly89/wpt that referenced this pull request May 6, 2019
Properties inherit or not according to the spec.
Properties have initial values according to the spec.
https://drafts.csswg.org/css-scrollbars/#property-index
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
Properties inherit or not according to the spec.
Properties have initial values according to the spec.
https://drafts.csswg.org/css-scrollbars/#property-index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants