-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-scrollbars] Inheritance, initial values #13647
[css-scrollbars] Inheritance, initial values #13647
Conversation
The inheritance tests were failing in Firefox when Changed the values used for inheritance testing, to allow the (The scrollbar-color initial value test still fails in Firefox.) |
It probably shouldn't test It's not completely clear whether it's what we want, though... Actually having |
Filed w3c/csswg-drafts#3237 for that. |
The latest nightly should pass all tests here now. |
The spec is clear that
@tantek Please review. |
But the result of gCS is resolved value, which is not necessarily computed value. Anyway the group has resolved on have keywords keep being keywords in resolved value. |
Thanks. I made the same mistake with caret-color and outline-color tests. Fixing those in |
042d09c
to
8ad7a42
Compare
Properties inherit or not according to the spec. Properties have initial values according to the spec. https://drafts.csswg.org/css-scrollbars/#property-index
8ad7a42
to
406f7d1
Compare
@upsuper Please review. I have updated the commit message so it no longer mentions Firefox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. auto
should work now given the resolution a while back.
Properties inherit or not according to the spec. Properties have initial values according to the spec. https://drafts.csswg.org/css-scrollbars/#property-index
Properties inherit or not according to the spec. Properties have initial values according to the spec. https://drafts.csswg.org/css-scrollbars/#property-index
Properties inherit or not according to the spec.
Properties have initial values according to the spec.
https://drafts.csswg.org/css-scrollbars/#property-index