-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-ui] expect resolved color in inheritance test #13748
Conversation
For the invert color of the outline-color property, you should check if the invert keyword is supported at all. If it is, it should be the initial value, but if it is not, having currentColor be the initial value is spec compliant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except for the comment I made in #13748 (comment).
Once that's fixed, this should be merged.
c1d06ba
to
3c50079
Compare
outline-color test now checks if 'invert' is supported. Blink/Firefox/Safari pass the outline-color test by not supporting 'invert', and returning the current rgb() color. Edge fails the outline-color test by accepting 'invert' but returning 'invert' from getComputedStyle() instead of the inverted background color. |
That's actually a pass. returning the inverted background color isn't actually possible, since background may not be a single color. returning 'invert' as a keyword is the right thing to do. |
Does that mean the UA should check whether the background is a single, opaque solid color (and if so, return that) or should it always return |
It should always return |
@ewilligers waiting for your changes to address comments before we merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good except for the point already raised by Florian
getComputedStyle returns the resolved color, not 'invert' or 'auto' https://drafts.csswg.org/cssom/#resolved-value outline-color initial value test now passes in Chrome/Firefox/Safari; they return the current rgb() color. Fails Edge, which returns 'invert' instead of a rgb() color.
3c50079
to
8a69c8d
Compare
Test updated, thank you for explaining. |
This PR is blocked on the required "Travis CI - Pull Request" check after #14499. In order to trigger it, I will close and reopen this PR. |
Comments have been addressed. outline-color test passes in Edge.
@frivoal's comments have been addressed. |
Ping. I believe this is ready for merging. |
getComputedStyle returns the resolved color or 'invert', not 'auto'
https://drafts.csswg.org/cssom/#resolved-value