Move more Travis jobs to TaskCluster #15724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
force-pushed
the
tc_unittest
branch
15 times, most recently
from
db2df52
to
ff1ce2d
Compare
jgraham
force-pushed
the
tc_unittest
branch
6 times, most recently
from
e254dae
to
f624961
Compare
jugglinmike
reviewed
Mar 14, 2019
gsnedders
approved these changes
Mar 15, 2019
|
I think the TC UI problems will be largely fixed when we are able to turn on the checks api. As far as I know that's still blocked on wpt.fyi, but @Hexcles may know more. Also they are redesigning the UI and I opened an issue about making the logs more prominent. @foolip Any concerns about merging this? |
|
I intend to merge this tomorrow in the absence of feedback to the contrary. |
|
That's OK with me! |
|
@jgraham is there an open issue or PR about enabling the checks integration for Taskcluster again? web-platform-tests/wpt.fyi#1182 is resolved now. @Hexcles, has that been deployed to prod as well? Can we confirm it working in prod before flipping the switch again? |
|
#15946 to reenable the checks API. |
|
Affirmative. And according to web-platform-tests/wpt.fyi#1183 (comment) , it's working. |
foolip
added a commit
that referenced
this pull request
Aug 23, 2019
Without the comma, the string literals are concatenated. Spotted via `sudo earlyoom -p -r 60--prefer=(chrome|firefox) --avoid=python` with a missing space in Taskcluster logs. This was introduced in #15724.
foolip
reviewed
Aug 23, 2019
| def start_userspace_oom_killer(): | ||
| # Start userspace OOM killer: https://github.com/rfjakob/earlyoom | ||
| # It will report memory usage every minute and prefer to kill browsers. | ||
| start(["sudo", "earlyoom", "-p", "-r", "60" "--prefer=(chrome|firefox)", "--avoid=python"]) |
There was a problem hiding this comment.
There's a missing comma here, sent #18630 to fix that.
foolip
added a commit
that referenced
this pull request
Aug 23, 2019
Without the comma, the string literals are concatenated. Spotted via `sudo earlyoom -p -r 60--prefer=(chrome|firefox) --avoid=python` with a missing space in Taskcluster logs. This was introduced in #15724.
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
Without the comma, the string literals are concatenated. Spotted via `sudo earlyoom -p -r 60--prefer=(chrome|firefox) --avoid=python` with a missing space in Taskcluster logs. This was introduced in web-platform-tests#15724.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 27, 2019
…ist, a=testonly Automatic update from web-platform-tests Add missing comma in earlyoom argument list (#18630) Without the comma, the string literals are concatenated. Spotted via `sudo earlyoom -p -r 60--prefer=(chrome|firefox) --avoid=python` with a missing space in Taskcluster logs. This was introduced in web-platform-tests/wpt#15724. -- wpt-commits: b3b48132272f9a92414ce879bd8a5ab468879b8f wpt-pr: 18630
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Aug 27, 2019
…ist, a=testonly Automatic update from web-platform-tests Add missing comma in earlyoom argument list (#18630) Without the comma, the string literals are concatenated. Spotted via `sudo earlyoom -p -r 60--prefer=(chrome|firefox) --avoid=python` with a missing space in Taskcluster logs. This was introduced in web-platform-tests/wpt#15724. -- wpt-commits: b3b48132272f9a92414ce879bd8a5ab468879b8f wpt-pr: 18630
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…ist, a=testonly Automatic update from web-platform-tests Add missing comma in earlyoom argument list (#18630) Without the comma, the string literals are concatenated. Spotted via `sudo earlyoom -p -r 60--prefer=(chrome|firefox) --avoid=python` with a missing space in Taskcluster logs. This was introduced in web-platform-tests/wpt#15724. -- wpt-commits: b3b48132272f9a92414ce879bd8a5ab468879b8f wpt-pr: 18630 UltraBlame original commit: 3842950c1e45d64e4ba8c131a589d209e1619dad
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…ist, a=testonly Automatic update from web-platform-tests Add missing comma in earlyoom argument list (#18630) Without the comma, the string literals are concatenated. Spotted via `sudo earlyoom -p -r 60--prefer=(chrome|firefox) --avoid=python` with a missing space in Taskcluster logs. This was introduced in web-platform-tests/wpt#15724. -- wpt-commits: b3b48132272f9a92414ce879bd8a5ab468879b8f wpt-pr: 18630 UltraBlame original commit: 3842950c1e45d64e4ba8c131a589d209e1619dad
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…ist, a=testonly Automatic update from web-platform-tests Add missing comma in earlyoom argument list (#18630) Without the comma, the string literals are concatenated. Spotted via `sudo earlyoom -p -r 60--prefer=(chrome|firefox) --avoid=python` with a missing space in Taskcluster logs. This was introduced in web-platform-tests/wpt#15724. -- wpt-commits: b3b48132272f9a92414ce879bd8a5ab468879b8f wpt-pr: 18630 UltraBlame original commit: 3842950c1e45d64e4ba8c131a589d209e1619dad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tc-jobs: all